public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 00/11] Remove some usages of find_inferior
Date: Sun, 19 Nov 2017 19:21:00 -0000	[thread overview]
Message-ID: <878tf2m5v3.fsf@redhat.com> (raw)
In-Reply-To: <1510943613-18598-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Fri, 17 Nov 2017 13:33:22 -0500")

On Friday, November 17 2017, Simon Marchi wrote:

> This is a random sampling of removals of find_inferior, replacing them with the
> new-ish find_thread/for_each_thread.

Thanks for the patch.  I looked over it, specifically the Linux-related
bits, and they seem fine.  Having hacked this code a bit on gdbserver
some time ago, I for one welcome this change.

> Simon Marchi (11):
>   Remove usage of find_inferior in win32-i386-low.c
>   Remove usage of find_inferior in win32-low.c
>   Remove usages of find_inferior in linux-arm-low.c
>   Remove usage of find_inferior in reset_lwp_ptrace_options_callback
>   Remove usage of find_inferior in iterate_over_lwps
>   Remove usage of find_inferior in unsuspend_all_lwps
>   Remove usage of find_inferior in linux_stabilize_threads
>   Remove usage of find_inferior when calling linux_set_resume_request
>   Remove usage of find_thread when calling resume_status_pending_p
>   Remove usages of find_thread when calling need_step_over_p
>   Remove usage of find_inferior when calling kill_one_lwp_callback
>
>  gdb/gdbserver/gdbthread.h      |  12 ++
>  gdb/gdbserver/linux-arm-low.c  |  55 +++++----
>  gdb/gdbserver/linux-low.c      | 248 ++++++++++++++---------------------------
>  gdb/gdbserver/win32-i386-low.c |  29 ++---
>  gdb/gdbserver/win32-low.c      |  12 +-
>  5 files changed, 137 insertions(+), 219 deletions(-)
>
> -- 
> 2.7.4

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

  parent reply	other threads:[~2017-11-19 19:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 18:33 Simon Marchi
2017-11-17 18:34 ` [PATCH 10/11] Remove usages of find_thread when calling need_step_over_p Simon Marchi
2017-11-17 18:34 ` [PATCH 11/11] Remove usage of find_inferior when calling kill_one_lwp_callback Simon Marchi
2017-11-17 18:34 ` [PATCH 09/11] Remove usage of find_thread when calling resume_status_pending_p Simon Marchi
2017-11-17 18:34 ` [PATCH 01/11] Remove usage of find_inferior in win32-i386-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 02/11] Remove usage of find_inferior in win32-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 05/11] Remove usage of find_inferior in iterate_over_lwps Simon Marchi
2017-11-17 18:34 ` [PATCH 03/11] Remove usages of find_inferior in linux-arm-low.c Simon Marchi
2017-11-17 18:34 ` [PATCH 04/11] Remove usage of find_inferior in reset_lwp_ptrace_options_callback Simon Marchi
2017-11-17 18:34 ` [PATCH 08/11] Remove usage of find_inferior when calling linux_set_resume_request Simon Marchi
2017-11-17 18:34 ` [PATCH 07/11] Remove usage of find_inferior in linux_stabilize_threads Simon Marchi
2017-11-17 18:34 ` [PATCH 06/11] Remove usage of find_inferior in unsuspend_all_lwps Simon Marchi
2017-11-19 19:21 ` Sergio Durigan Junior [this message]
2017-11-20  3:24   ` [PATCH 00/11] Remove some usages of find_inferior Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878tf2m5v3.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).