From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72398 invoked by alias); 12 May 2015 22:02:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72386 invoked by uid 89); 12 May 2015 22:02:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 May 2015 22:02:37 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C8DDC8F024; Tue, 12 May 2015 22:02:35 +0000 (UTC) Received: from localhost (unused-10-15-17-126.yyz.redhat.com [10.15.17.126]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4CM2ZNb028349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO); Tue, 12 May 2015 18:02:35 -0400 From: Sergio Durigan Junior To: Doug Evans Cc: Gabriel Krisman Bertazi , palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH v4 0/4] catch syscall group References: <001a11c3b928756ec20515e95aba@google.com> X-URL: http://blog.sergiodj.net Date: Tue, 12 May 2015 22:02:00 -0000 In-Reply-To: <001a11c3b928756ec20515e95aba@google.com> (Doug Evans's message of "Tue, 12 May 2015 21:41:12 +0000") Message-ID: <878uctjvyg.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00289.txt.bz2 On Tuesday, May 12 2015, Doug Evans wrote: > > Also, this patch series *does not* include the generated files because > > they are too big and can get in the way of code review. Reviewers must > > generate those files by hand by entering the gdb/syscalls directory and > > running the makefile there. Build will fail if reviewer don't do this! > > Once we get this approved, I'll make sure to include the generated files > > in the commit before pushing. Hopefully this will make code review > > easier. > > This sounds like something we should key off of --enable-maintainer-mode. > [we *could* use a different option if people are wedded to > --enable-maintainer-mode affecting only autogen files, but > that seems like overkill] What exactly are you refering to? Generating the XML files using xsltproc when compiling GDB? I will assume this in the rest of the message, but if that's not what you meant, then please disconsider. > IIRC we don't do that for, e.g., gdbarch.sh -> gdbarch.[ch], but > that's a mistake IMO. Let's get it right here. Sorry, but what is the point of regenerating files that do not change every time we compile GDB? I fail to see that. > It will mean that configuring with --enable-maintainer-mode > will now require xsltproc, but that's the price of going down > this path, let's not hide it. > [maybe that's a good reason to use something other than > --enable-maintainer-mode, but > 1) how often do people configure with --enable-maintainer-mode, and > 2) maintainers are expected to know and accept these dependencies] They will know and accept the dependencies if they really need to regenerate the files, of course. Other than that, I still don't see any practical reason to impose this on anyone who is compiling GDB, whether this person is a GDB developer or not. I don't necessarily oppose hooking the XML generation into the --enable-maintainer-mode option, but I'm having the impression that we are bloating this feature more and more, without much gain. Unless I'm really blind to some benefit, in which case I apologize in advance. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/