From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Clear upper bits during sign extension
Date: Mon, 29 Dec 2014 06:27:00 -0000 [thread overview]
Message-ID: <878uhrvumr.fsf@codesourcery.com> (raw)
In-Reply-To: <CADPb22S97uP=UbNp4XZvoLtrN0msnFNwEKxoHU88nrDMpwx=rQ@mail.gmail.com> (Doug Evans's message of "Sun, 28 Dec 2014 21:29:22 -0800")
Doug Evans <dje@google.com> writes:
> It's not immediately clear to this reader that undefined behaviour is
> avoided here.
> E.g., what if sizeof (LONGEST) == 8 && bit == 64.
How about returning VALUE simply in this case? like the patch below,
--
Yao (齐尧)
gdb:
2014-12-29 Yao Qi <yao@codesourcery.com>
* utils.c (gdb_sign_extend): Do sign extension if BIT is less
than 8 * sizeof (LONGEST). Clear bits from BIT in VALUE.
diff --git a/gdb/utils.c b/gdb/utils.c
index 47adb67..83a6df6 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -3028,10 +3028,13 @@ gdb_sign_extend (LONGEST value, int bit)
{
gdb_assert (bit >= 1 && bit <= 8 * sizeof (LONGEST));
- if (((value >> (bit - 1)) & 1) != 0)
+ if (bit < 8 * sizeof (LONGEST) && ((value >> (bit - 1)) & 1) != 0)
{
LONGEST signbit = ((LONGEST) 1) << (bit - 1);
+ /* Clear upper bits from bit BIT. */
+ value &= (signbit << 1) - 1;
+
value = (value ^ signbit) - signbit;
}
next prev parent reply other threads:[~2014-12-29 6:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 1:13 Yao Qi
2014-12-29 3:07 ` Joel Brobecker
2014-12-29 3:38 ` Yao Qi
2014-12-29 3:53 ` Joel Brobecker
2014-12-29 5:29 ` Doug Evans
2014-12-29 6:27 ` Yao Qi [this message]
2014-12-29 10:48 ` Pedro Alves
2014-12-30 9:20 ` Yao Qi
2014-12-30 12:20 ` Pedro Alves
2014-12-30 13:47 ` Yao Qi
2015-01-08 5:40 ` Yao Qi
2015-01-08 10:42 ` Pedro Alves
2015-01-08 13:06 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uhrvumr.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).