From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21440 invoked by alias); 13 Jan 2014 20:21:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21427 invoked by uid 89); 13 Jan 2014 20:21:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2014 20:21:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0DKLbKM032597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Jan 2014 15:21:37 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0DKLabD015593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Jan 2014 15:21:36 -0500 From: Tom Tromey To: Doug Evans Cc: gdb-patches Subject: Re: [PATCH 3/3] move the "main" data into the per-BFD object References: <1389028297-16977-1-git-send-email-tromey@redhat.com> <1389028297-16977-4-git-send-email-tromey@redhat.com> <87vbxxm1nh.fsf@fleche.redhat.com> <874n5glsst.fsf@fleche.redhat.com> Date: Mon, 13 Jan 2014 20:21:00 -0000 In-Reply-To: <874n5glsst.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 06 Jan 2014 14:11:14 -0700") Message-ID: <878uuj1vlb.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00376.txt.bz2 Doug> Can I ask for a comment in the code explaining why things are the Doug> way they are. Tom> Sure. I added this: /* First check the objfiles to see whether a debuginfo reader has picked up the appropriate main name. Historically the main name was found in a more or less random way; this approach instead relies on the order of objfile creation -- which still isn't guaranteed to get the correct answer, but is just probably more accurate. */ Tom