From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/5] Associate target_dcache to address_space.
Date: Wed, 23 Oct 2013 16:37:00 -0000 [thread overview]
Message-ID: <878uxkdjv3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1382516855-32218-3-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 23 Oct 2013 16:27:32 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> Nowadays, 'target_dcache' is a global variable in GDB, which is not
Yao> necessary. It can be a per-address-space variable. In this patch, we
Yao> add a new structure 'target_dcache', which includes all dcaches of
Yao> target and all of them are per-address-space.
I like this patch quite a bit. For one thing, it fixes the target
dcache for the coming multi-target work :-)
Yao> +/* The current added space. */
Yao> +#define current_address_space current_program_space->aspace
On the whole I would prefer we not add new object-style macros like
this. (Actually I'd really like it if we got rid of the existing ones
too...) Writing out the expansion in the few places it is used seems
better to me.
Yao> +static void
Yao> +target_dcache_cleanup (struct address_space *aspace, void *arg)
Yao> +{
Yao> + struct target_dcache *dcache
Yao> + = address_space_data (aspace, target_dcache_aspace_key);
Yao> +
Yao> + target_dcache_xfree (dcache);
Here you don't need to call address_space_data, since ARG is the dcache
that was passed in.
Tom
next prev parent reply other threads:[~2013-10-23 16:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 8:29 [PATCH 0/5] Cache code access for disassemble Yao Qi
2013-10-23 8:29 ` [PATCH 2/5] Associate target_dcache to address_space Yao Qi
2013-10-23 16:37 ` Tom Tromey [this message]
2013-10-24 8:33 ` Yao Qi
2013-10-28 20:49 ` Tom Tromey
2013-10-28 21:51 ` Doug Evans
2013-10-23 8:29 ` [PATCH 5/5] set/show code-cache NEWS and doc Yao Qi
2013-10-23 15:25 ` Eli Zaretskii
2013-10-24 8:26 ` Yao Qi
2013-10-24 15:21 ` Eli Zaretskii
2013-10-25 9:35 ` Yao Qi
2013-10-25 10:01 ` Eli Zaretskii
2013-11-02 0:25 ` Yao Qi
2013-11-02 7:06 ` Eli Zaretskii
2013-10-23 8:29 ` [PATCH 4/5] Use target_read_code in disassemble Yao Qi
2013-10-23 8:29 ` [PATCH 3/5] set/show code-cache Yao Qi
2013-10-25 7:47 ` Doug Evans
2013-10-25 14:35 ` Yao Qi
2013-10-25 15:57 ` Doug Evans
2013-10-26 13:24 ` Yao Qi
2013-10-28 18:33 ` Doug Evans
2013-10-23 8:29 ` [PATCH 1/5] Add REGISTRY for struct address_space Yao Qi
2013-10-28 20:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878uxkdjv3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).