Re: [PATCH 13/16] gdb: allow 'set args' and run commands to contain newlines

[Andrew Burgess <aburgess@redhat.com>]

Keith Seitz <keiths@redhat.com> writes:

> On 10/23/24 6:01 AM, Andrew Burgess wrote:
>> Keith Seitz <keiths@redhat.com> writes:
>>> I'm noticing some extra newlines output with this new command if you
>>> use ^d to interrupt entering input:
>>>
>>> (gdb) set args "
>>>   > <!-- hit ^d -->quit
>>> (gdb) show args
>>>
>>> Argument list to give program being debugged when it is started is "".
>>> (gdb)
>>>
>>> Notice the extra newline output after the last command.
>> 
>> I know it's been a while, but can you give any more details about the
>> environment in which you saw this extra newline bug?
>> 
>> I rebased this series onto a recent master and it doesn't reproduce for
>> me.
>
> I obviously haven't tried rebasing anything, but with the full
> original series applied, I can easily reproduce this:
>
> Compare:
> $ ./gdb -nx -q
> (gdb) show args
> Argument list to give program being debugged when it is started is "".
> (gdb)
>
> and
> $ ./gdb -nx -q
> (gdb) set args "
>  >^Dquit
> (gdb) show args
>
> Argument list to give program being debugged when it is started is "".
> (gdb) set args foo
>
> (gdb) show args
>
> Argument list to give program being debugged when it is started is "foo".
> (gdb)
>
> [note all the newlines]
>
> I don't think there is anything "special" about my setup, I'm pretty
> much running vanilla Fedora 40.

Keith,

Thanks for confirming the details for this.  I was able to reproduce
this issue.  Turns out it's not related to this patch, but is a general
issue relating to secondary prompts and EOF (Ctrl+d).  You can reproduce
it like:

      Reading symbols from /tmp/hello.x...
      (gdb) break main
      Breakpoint 1 at 0x401198: file hello.c, line 18.
      (gdb) commands
      Type commands for breakpoint(s) 1, one per line.
      End with a line saying just "end".
      >quit                 # <----------- Use Ctrl+d to quit here.
      (gdb) show architecture
                            # <----------- This blank line is unexpected.
      The target architecture is set to "auto" (currently "i386:x86-64").
      (gdb)

I've posted a series to fix this issue here:

  https://inbox.sourceware.org/gdb-patches/cover.1730303479.git.aburgess@redhat.com

I'll handle these two issues separately moving forward.

Thanks,
Andrew