From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7BCB5385DDE4 for ; Tue, 11 Jun 2024 19:52:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BCB5385DDE4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BCB5385DDE4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718135554; cv=none; b=G6yxte1BCOBlyPMX5wRlSUR/mNTlHRkvKnRfM4jQvzlG+713pZ2pMgS/6FPZRSwFklylQ3H66/yZNvdTeTKgsHlwtdJAyrDfELrkQWSxbM6W7sXlLozrbLPCboRhH8PwYxxeF2pmx7SOJmO+BNPPj69yVmkgv1LzynJsGLK2KWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718135554; c=relaxed/simple; bh=7kDW/F2SpDxZzwWivm1Ph9CHwiYaIHjq9s9x1UI+klA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IY8PdTn1vaRVSMdNppFzC61mADQigfI5Rux/AOpPyBNim1P36C271kcnE5gUqeQfRYpDUZYdbyo7zUg0ryPvk/zu5dCTF1sUL7otF484sE36nv7XkJCIySnt5jpOARfLC6JxWfc66nylv13eb8O4t8Yb9Bj+DJJwfG/5zo7udoA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718135553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B8KZvFKjOCU6eUkf50HiVSDg1mFyEqsYgwppTLlCwxs=; b=d/X8i+OMu4jp7G1C92gVdmh9XgYVXVm5bK3MbRXRcROK/yux2/d/w/GTO4TQIgTcL9M1JK 6UMK1DtpfEYJAH8T9/D8OYXWsj0buX2geJ3onrwPhRECK5ZWW3xDI4F+Rs8NoP+QM5xChM oWdSGmQePrmYNmmL8YwUEs/ek2qvGB4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-XvmaiMGpP4OmPJZIeDm4Sw-1; Tue, 11 Jun 2024 15:52:32 -0400 X-MC-Unique: XvmaiMGpP4OmPJZIeDm4Sw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35f21956382so2154840f8f.0 for ; Tue, 11 Jun 2024 12:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718135549; x=1718740349; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B8KZvFKjOCU6eUkf50HiVSDg1mFyEqsYgwppTLlCwxs=; b=aV6a3000a1wWS5mtNGkxn4//JYn/k5bDXe0P1PPlBS/nrhiDEAHCQ8RlbbydG+3X1Y fpY69pojonJG4+/G2xoMUpL6u6wYZ+st0AS5RdcfPAt94QeC8Ar/01YI69JIpgwvwdrP MsT3keRq/kL9u6aWe/EmKn62++QGb4QZXo0a9/Tkhf6jOJ8nX9F+n3Roe1mapQTGFfnI nRSQMldsi5XL7lBQHtvQKqq+Tj21WY6Fsa9o9otVxgBffIO3DRa7aZ/TnCJJeZI5IjWM sWXW/QznYy0++L0pC4caIMXOw9SZ/0HIAGirXKXd0/zq/Fc/CR2D92TfNVH6QtxyAQUi hioQ== X-Gm-Message-State: AOJu0YxKe5nNYRkgkbUY7JNwsvHpZO/njMUdfZgwHBBwrG6ci/ExtI/y r7jpHHvbcUH53lp+UmQGB8yWzHFrxPQtQxifNV4248T5+h9HCDeWEcae5WzkFRHjPLPKaLhCwiG 8thTldx7aa32voy8GASzIEG2AMACmJdFGjbKwCKdsCGzmEKH9BS0UHB6DQQ9EDlKyS7s= X-Received: by 2002:a5d:4a0b:0:b0:35f:a0c:7cf1 with SMTP id ffacd0b85a97d-35f0a0c7ff8mr7748942f8f.34.1718135549605; Tue, 11 Jun 2024 12:52:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTZyQZtGibPg0g/UbhkvxZct2z0WpFNv4shMrKdA0nlHrotcsoaRoap6CoyePIxTxVK6TlcQ== X-Received: by 2002:a5d:4a0b:0:b0:35f:a0c:7cf1 with SMTP id ffacd0b85a97d-35f0a0c7ff8mr7748932f8f.34.1718135549170; Tue, 11 Jun 2024 12:52:29 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f29629231sm4400512f8f.67.2024.06.11.12.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 12:52:28 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] gdb/fileio: fix errno for packets where an attachment is expected In-Reply-To: <87sexqm2yn.fsf@tromey.com> References: <87sexqm2yn.fsf@tromey.com> Date: Tue, 11 Jun 2024 20:52:28 +0100 Message-ID: <87a5jr9s03.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> I ran into this issue while working on another patch. In that patch I > Andrew> was checking the error code returned by a remote readlink call and > Andrew> spotted that when I passed an invalid path I got EINVAL instead of > Andrew> ENOENT. This patch fixes this issue. > > Andrew> Unfortunately the patch I was working on evolved, and my need to check > Andrew> the error code went away, and so, right now, I have no way to reveal > Andrew> this bug. But I think this is an obviously correct fix, and worth > Andrew> merging even without a test. > > Makes sense to me. Thanks for the clear explanation. > Approved-By: Tom Tromey Pushed. Thanks, Andrew