public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Dmitry Neverov <dmitry.neverov@jetbrains.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3][PR symtab/30520 v2 1/4] gdb/symtab: check name matches before expanding a CU
Date: Fri, 10 May 2024 12:39:09 -0600	[thread overview]
Message-ID: <87a5kx1pgy.fsf@tromey.com> (raw)
In-Reply-To: <20240508202219.3584915-1-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Wed, 8 May 2024 22:22:16 +0200")

>>>>> "Dmitry" == Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:

Dmitry> From: "Dmitry.Neverov" <dmitry.neverov@jetbrains.com>
Dmitry> The added check fixes the case when an unqualified lookup
Dmitry> name without template arguments causes expansion of many CUs
Dmitry> which contain the name with template arguments.

These all look reasonable to me... what is the status of the copyright
assignment now?  I'm wondering if we can land them.

Tom

  parent reply	other threads:[~2024-05-10 18:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 20:22 Dmitry Neverov
2024-05-08 20:22 ` [PATCH v3][PR symtab/30520 v2 2/4] gdb/symtab: reuse last segment lookup name info by creating it outside the loop Dmitry Neverov
2024-05-08 20:22 ` [PATCH v3][PR symtab/30520 v2 3/4] gdb/symtab: compute match_type " Dmitry Neverov
2024-05-08 20:22 ` [PATCH v3][PR symtab/30520 v2 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name Dmitry Neverov
2024-05-10 18:39 ` Tom Tromey [this message]
2024-05-17 14:01   ` [PATCH v3][PR symtab/30520 v2 1/4] gdb/symtab: check name matches before expanding a CU Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5kx1pgy.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=dmitry.neverov@jetbrains.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).