From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 788F538460B1 for ; Wed, 3 Apr 2024 14:59:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 788F538460B1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 788F538460B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712156395; cv=none; b=ovRAB5YZQrcoS3tCB5QujSvxvownmZZ2rVLV99ATOGWYwOcnQlrIJWqPh9TAPMtDU4gzR3qehkk1dxa63SKUSnVsz5EyhfQ3g3oVCsNwnPXfBo+sFyK4HiLEGTvF8O86ZDNX6MESZopEmsgKtdH0jIZljr5TVEXLqHhUK7bmXvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712156395; c=relaxed/simple; bh=Qf7dE9tnPkMpqNzvw71URrpi+9I2ZNWfUe0Q8Yf6muM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=taaSJ3epSob6OhbAs0kBIf3OZTMXkmyuNRyXtMo02TYNi+tOx5dhAHOl5RLZSk2zDfc5BlcUZuVs7ETAHfIyFS1lOSloHYVwX4WibgROxdhbENfm7OgM9xIL0Aw4T9gIq5jlDDHiIvnFjJSL3ibLcxzo5S4N8CO6S5dUArVo6Dc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id rsRvrLErTHXmAs25hr2w1s; Wed, 03 Apr 2024 14:59:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id s25hrSk23bhc1s25hrxlzO; Wed, 03 Apr 2024 14:59:53 +0000 X-Authority-Analysis: v=2.4 cv=Z7bqHmRA c=1 sm=1 tr=0 ts=660d6ee9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zd2uoN0lAAAA:8 a=zstS-IiYAAAA:8 a=0xIbOhTuW4VjLfZjNHkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3tn7uoeFVNJ9b7AxiyMKmmZPv7EipjS1LNOmBFxh9mA=; b=f2VjT7hFjEX0IomnY3CiW52KrK rkZRdtjDu7yD3gcvRvXFm5eQ4u5ca0JA4cKbm/UkgSlkv31ld2fzjdBMscg1WYEQWxuIrddpH4xSJ bNhgDMtUJEpSwr3ro4k30Ltsb; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:35458 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rs25g-003Z6q-2T; Wed, 03 Apr 2024 08:59:52 -0600 From: Tom Tromey To: Lancelot SIX Cc: , Subject: Re: [PATCH] Revert "gdb/compile: Use std::filesystem::remove_all in cleanup" References: <20240403144446.39094-1-lancelot.six@amd.com> X-Attribution: Tom Date: Wed, 03 Apr 2024 08:59:52 -0600 In-Reply-To: <20240403144446.39094-1-lancelot.six@amd.com> (Lancelot SIX's message of "Wed, 3 Apr 2024 15:44:46 +0100") Message-ID: <87a5ma8pav.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rs25g-003Z6q-2T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:35458 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAViOiRAFBsQZUKtzM3TpA78Vn2tBkij9CR9Gmb+tF/wbLmxGuXD/w0CliMWFfda0k1r9T3DQi/sFlI8coh0M5LMaDPUh32BOa73o2zU0VMIcCIv6j7z SIcyKrODecJZ/7cj2woPaZOIldsRwdMhnu/GWxPJHFgI8nl4bWt8Yj38MPDPlIQYNPInegP+q2tsGRgDfQGHQMgrsYqad74dnO0= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Lancelot" == Lancelot SIX writes: Lancelot> This reverts commit 7bba0ad08576309763e3f41193eaa93025e10b8b. Lancelot> Tom de Vries reported that 7bba0ad0857 (gdb/compile: Use Lancelot> std::filesystem::remove_all in cleanup) broke builds with gcc-7.5.0 Lancelot> which mostly supports c++17, but not std::filesystem[1]. As this change Lancelot> is not critical, revert it to maintain compatibility. Thanks. Could you put the 'Bug:' tag into this so it's recorded in bugzilla? Sorry to say it but this is ok. I appreciate your quick turnaround on it. Approved-By: Tom Tromey Tom