From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 7F3953858D20 for ; Tue, 20 Feb 2024 15:38:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F3953858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F3953858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708443506; cv=none; b=wSq7LHIrKRcIinlCldHQunOx4hNBTiOmSVQoAuJYz01g4faAPwO5xxWGYB8xGuYHVnCvMwB9iZv8dPiED6F+1kgZ2TisrqnU8TqYV0fmpmHi9iA2iJO/lBWTj19UWQ/xX1oith3MtQBKlM0fDbrKeHXHLG3FnZbFAEf/kXSBz1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708443506; c=relaxed/simple; bh=7bS9r39iuNPXWS7L66YmYlHFuijK+XSyhTHu4oLVSno=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qLsZwZhKQ+CmV1UBlLbp2SOaJxtQdIxax+igcTbe4dbn+GgDGSsL+Qu6oyEyquSliLRuoGY5Pn2b1AW/jhDuGJPDKHdg4d47lB+gyYaBEKrVMQJugkDr8JESGMk1CTzMZW88/t3iLVRxvmEq7nCCWJC5pEna+u+IxXpjW0ae2RU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6007a.ext.cloudfilter.net ([10.0.30.247]) by cmsmtp with ESMTPS id cKPQrx5pICF6GcSCMrkaPf; Tue, 20 Feb 2024 15:38:22 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id cSCLrtnQKxVAXcSCMrKHvG; Tue, 20 Feb 2024 15:38:22 +0000 X-Authority-Analysis: v=2.4 cv=LokxyWdc c=1 sm=1 tr=0 ts=65d4c76e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=IWgrIlfUiL5UnXY--DMA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xIUrE8oa0hrvgFsHKcjEsA46PTfld+LNWmaTgOxbAL0=; b=rsGZdhGYg5qT9QOycjqD7jHnN2 39gJQwXG8iL4SQk9r6nhXupav9EVyFNz0Lbk55n0xafYqM8xg0ZhVAcJrTCthnGE7Pm5CavOGDzSz yKU6CX9aQi16zwKweMXyO9qC1; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:38786 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rcSCL-003uSH-1U; Tue, 20 Feb 2024 08:38:21 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] [gdb/dap] Fix race between dap startup and dap log file References: <20240219082341.21313-1-tdevries@suse.de> <20240219082341.21313-5-tdevries@suse.de> X-Attribution: Tom Date: Tue, 20 Feb 2024 08:38:20 -0700 In-Reply-To: <20240219082341.21313-5-tdevries@suse.de> (Tom de Vries's message of "Mon, 19 Feb 2024 09:23:38 +0100") Message-ID: <87a5nv2ljn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rcSCL-003uSH-1U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:38786 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfB5v0F8mbhNzeJuF1HZ8Q+4/jVNpJ7ZjgyemdYyCk9blQ/iietgwZfwABUR2KQGpeQNDojoz06CpJgjfeuibccpWhudrBgibOR3ZB4jTAY+rkC6s5a6u 9YOuX9i3TGk4/bFoV6labcB7CIWp8l2N7n6JpjJ9CXFdGK9KbgOwyiUb4f/O41P01Oj0PPhg1RXPsJJgz8ROQNFUwJEZ741td5c= X-Spam-Status: No, score=-3016.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Fix this by: Tom> - initially logging to a string instead, and Tom> - dumping the string to the log file once the log file is initialized. Tom> This has the drawback that the string can keep growing indefinitely if a log Tom> file is never set, this will be addressed in a following commit. I don't like this approach. There's almost never any need to log anything, so I think this is adding complexity to something where, really, we don't care. IMO most of the early logging isn't even useful. In the bug you pointed out how dap.run logs some commands early on... but even this is just because it is convenient to call exec_and_log, not because these logs are useful. Tom