From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id D035A3858D33 for ; Tue, 6 Feb 2024 17:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D035A3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D035A3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707240172; cv=none; b=hQNunhGNzMn7EPdy6OFvIw1KcT4KvoSQ+BTEtnZS4g0ftZ2qXVBkRPYqQQW63wWNwWR9B9lklHj0ljWLIgyHT/0bfWtBdfk71bKCwQNeB34D7tHTyJu95dIzlXCsL5PSyh0TQkJeWBzLYAxMfpsWRBHhzambV06Zmw6ONwDmGyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707240172; c=relaxed/simple; bh=m0tiuixwDurVc+usL5OkAXRsohF6NctvcRH3ct42DXE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PT3hANdNP2Guwz2Xj+YQXQjRAgWk7lOWNZPKuQTRNNICDJS7WOjSLp3u1XMrMmhV4kUxIKP4wHvPVUvad2gR1Ppmo1yg3+3z69nz6DH823lHorMzGzo+Rt1vACGs9n5AhnYOwUgpcMFFSMt1DBskLCMDTfd3ddzVqCYAiHMWzKs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id X88mrbJ3WpUFLXP9jr7NVx; Tue, 06 Feb 2024 17:22:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id XP9irqtcd0Gr5XP9jrd00r; Tue, 06 Feb 2024 17:22:47 +0000 X-Authority-Analysis: v=2.4 cv=MKvDm9Zl c=1 sm=1 tr=0 ts=65c26ae7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=MAUEHVIq7l3xAFPipfcA:9 a=rRgZbCAznXwA:10 a=JLvreUVHyG8A:10 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C4xwrY8LNQGbUISqlj1AsyoDgU1TrnwfDm6PBZyx32U=; b=hr5/Dc1NI0RWZ948TSxmYcI+Im B2Pc0Doy34gP44oHLIHL3lHRplcEOPLFEycOVJvn2XUZe+i3Ogt/PCKUbAVYlr+0xqES0VFA5r/I5 simRjffY8JNDMPKhld3h7gFz6; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:40090 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rXP9i-000C1Z-19; Tue, 06 Feb 2024 10:22:46 -0700 From: Tom Tromey To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org, blarsen@redhat.com, tom@tromey.com, aburgess@redhat.com Subject: Re: [PATCH v5] gdb, python: selectively omit enabling stdin in gdb.execute References: <877cmiq6fu.fsf@redhat.com> <54fb15ec3abb7a1f7f0714094365feb0d5197489.1700510882.git.tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Tue, 06 Feb 2024 10:22:45 -0700 In-Reply-To: <54fb15ec3abb7a1f7f0714094365feb0d5197489.1700510882.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Mon, 20 Nov 2023 21:21:54 +0100") Message-ID: <87a5odecd6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rXP9i-000C1Z-19 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:40090 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNv/kNh9snqKMOgTrSQ6WrvrO1eQc0fpSwU6VX48Pxvcbc0rd9QoO9iZYWs4epZIEnmYDcWyQygdkB1YGH2JZdHcuA3fGMvtZwgh5LIhLePZKbESG++q lkIAeRkpQzmNfHa3mxQRHzslz/9qf/fFNjrmOpQqChV6jQOHkUt+2wHJFjK36Z1GX7G68S3HJ8XZIBNVyw67jrauErdbzhYAH1U= X-Spam-Status: No, score=-3016.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Tankut Baris Aktemur writes: > The previous revision (v4) of this patch can be found at > https://sourceware.org/pipermail/gdb-patches/2023-November/204107.html > Changes in this version: > * Revised the commit message to address Andrew Burgess' concerns in > https://sourceware.org/pipermail/gdb-patches/2023-November/204215.html > * Made a minor change to a code comment. I didn't see a response to this. I think this whole area is pretty ugly, but at the same time, I don't think that's your fault. In short I think this is OK. Approved-By: Tom Tromey thanks, Tom