From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 644AC385802D for ; Tue, 9 Jan 2024 20:11:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 644AC385802D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 644AC385802D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704831090; cv=none; b=DgH9cuVzMT9pYLdLCoZk1DrC3Ht1gUqSjt6msnLL5cLxSpDwPb17e591y2kdr6CuMJzrUGXwysL+S4gNmn2aRHao4v7cxqhdTc6p5Yq8qjKEQXwAh5oNF2Vi/XLBnJn1q12I4sEmwyZ8C6fuqc+RB2icKuUD5vXs5YHDqlu+ZSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704831090; c=relaxed/simple; bh=oA/JtKvZAFgj7r/ZSrsmCOLlDYoe0a4iu6pbh5xK2OQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=od+lR9qpTQNxdm+jAXjQasjPJ4RMbH4jSiUASXoeZqcK9SyzsfDyDw7HnvU7z7wb4WEkKbmqItceTEUORJ4X4WgBN43UV3vEQ5TQELrqy4RiX7sb39cV8RzMNYpVT0xlSDVKmAkC7v9J6bBaLQHQuO0vszynTOvrB0r3CuwiGbs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5005a.ext.cloudfilter.net ([10.0.29.234]) by cmsmtp with ESMTPS id NH9drIMCrAxAkNIRrr4zse; Tue, 09 Jan 2024 20:11:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id NIRcrvjX4fs4hNIRcrDGac; Tue, 09 Jan 2024 20:11:28 +0000 X-Authority-Analysis: v=2.4 cv=Q6TBXq6a c=1 sm=1 tr=0 ts=659da870 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=_0lg9gpnEp4A0BDjkfoA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BOpEPLYfaf5EoSQ3gI0qHXVX0pjs6BRokcKmRsHgb4w=; b=p0HKadCUg7jdsEyGDXzRmZ8rLh h8w94I8hBUnlmA+zbf1+HtvYzlV4Ewjo4OJ7LcNXQslwXFEmkgKHb3Q/ucCVb4QGfnprAu/T4kM01 bHM+VvOY94qIvmo23FM2SGPMj; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:35338 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rNIRb-002qQ0-2S; Tue, 09 Jan 2024 13:11:27 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] gdb/python: Add gdb.InferiorThread.__dict__ attribute References: <6fdf97c5f147a7e71fc0ca4de9e49961c067bae1.1704455158.git.aburgess@redhat.com> X-Attribution: Tom Date: Tue, 09 Jan 2024 13:11:27 -0700 In-Reply-To: <6fdf97c5f147a7e71fc0ca4de9e49961c067bae1.1704455158.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 5 Jan 2024 11:48:35 +0000") Message-ID: <87a5petggg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rNIRb-002qQ0-2S X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:35338 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJzXn3Q4JKkZSyn9/wl6FxDZe5AXQ4uRdGQ3HHPCFrNkPut1oqGx1tIcnPXXXer+HRRPEDsOaZv3Z8jKgIoX8zGjeI7blocm1++Ue0+qlBEwwckTR15c iGxOHOc8PfhSjyJvrCU78FlQHOFe2DbfdKjM/GFTmc6Bue2YsJiiZ2WP8FXO3Vm8ef0Jm77P9UaXO54DUSGq+FqIj0AzSt8iWVQ= X-Spam-Status: No, score=-3016.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> + thread_obj->dict = PyDict_New (); Andrew> + if (thread_obj->dict == nullptr) Andrew> + return nullptr; If this fails... Andrew> static void Andrew> thpy_dealloc (PyObject *self) Andrew> { Andrew> - Py_DECREF (((thread_object *) self)->inf_obj); Andrew> + thread_object *thr_obj = (thread_object *) self; Andrew> + Andrew> + gdb_assert (thr_obj->inf_obj != nullptr); Andrew> + gdb_assert (thr_obj->dict != nullptr); Andrew> + Andrew> + Py_DECREF (thr_obj->inf_obj); Andrew> + Py_DECREF (thr_obj->dict); ... won't this be called and then crash because dict is NULL? I am not really sure TBH but other code, like your change in py-inferior.c, seems to think this. I suspect Py_XDECREF should be used instead. The current call to Py_DECREF isn't a bug because create_thread_object avoids creating the thread object when 'inf_obj' would be null. But, the new patch doesn't do this. Tom