From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 807173857354 for ; Sun, 5 Nov 2023 16:34:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 807173857354 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 807173857354 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699202100; cv=none; b=tP9ebaqKlskj0kK+U94QgeuhDGsZUR7NMS1m+a5WjM+SFALFG1eNUZ2moa3QHAphAnIJaZ/SA8bK39HRddbltpE/NtCFHz8/YTF2MZOdGzOKlEayyrrjp26zd4LxIDZth07+ykAmleXuf2+AoAhqmsOs7uhhJBufOVQvsXtIJ7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699202100; c=relaxed/simple; bh=eRv7y5z7Jn1j+eDct+U7cC+f+PjmUsEqmtoC0QDl7CM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=H5W+jG+nYH9zdOvFFNLUaNq9XDwcWuBMuCiNxX0Et0auY9UAu3VYy8PmQhaIVB5fYrzBFXi+DmQ31FKZeaELaH+L/yjavEdBILluGydxhfhJsZ1T75EaKWFGkJnH8In1sHy6yJ87CCBxCKHMGY70OCtBxYPhDyh2uz7HGsCwlVM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id zFJsqXvqgWcCIzg5QqQDtE; Sun, 05 Nov 2023 16:34:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zg5PqDJT5wasUzg5QqTHnc; Sun, 05 Nov 2023 16:34:56 +0000 X-Authority-Analysis: v=2.4 cv=ZpP+lv3G c=1 sm=1 tr=0 ts=6547c430 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=dzWzf_mpAAAA:8 a=Y3-KjVejQloL6yhsCnIA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=y0qb4Hu2tjAnAgGV8d0WtrCkWiEwL6jHba+KoFxLuVE=; b=G6b3122iXb5EvlcZhG8QmcexTe zYF6YcoseVZvEd7f1oa9b//iqNkJVQVXEwfc/hbfm22N0L3qUGzF2LWhX4ERh3kavp/v2zubPo8aq p/NRLjkAngK3TxB6Xcb7E1OFN; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:60654 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qzg5P-002R3o-1T; Sun, 05 Nov 2023 09:34:55 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 04/30] Use block_symbol::address in ada-tasks.c References: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com> <20231029-split-objfile-2023-bound-sym-october-v1-4-612531df2734@tromey.com> <27cfe94f-cabe-4260-af43-2244f4472e81@simark.ca> X-Attribution: Tom Date: Sun, 05 Nov 2023 09:35:15 -0700 In-Reply-To: <27cfe94f-cabe-4260-af43-2244f4472e81@simark.ca> (Simon Marchi's message of "Thu, 2 Nov 2023 23:40:55 -0400") Message-ID: <87a5rstayk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qzg5P-002R3o-1T X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:60654 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfC3uxhDKyr3fl3WNzMJZAP/EbPMQkIJn5tPtzRHJ9Wj+BrqPcnAUVBmvknG0gDDGcJ9pmzr9jDy0Haav5LpJ68ipNQ/sLEENn6LujG6u4Mbze0pSXDKY Sa6gWkZPNRkfmk3arlrp844extqqP0NCV3uU3r1gCe/SxRQpVT5Aa1jWwJD2XSE1hMGhaycIW4jkmCL3AYZioO6ldrrB3NexZCE= X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> struct bound_minimal_symbol msym; >> - struct symbol *sym; >> + struct block_symbol sym; Simon> I'd suggest declaring separate sym variables in the two scopes where Simon> it's needed (ideally where it's initialized). This helps show that the Simon> two uses are not related and specific to those scopes. I made this change. Tom