From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id ABBEC3858D3C for ; Wed, 13 Sep 2023 03:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ABBEC3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1d4e0c2901bso4167949fac.0 for ; Tue, 12 Sep 2023 20:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694574222; x=1695179022; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=C1mvv2fqoAPFPTYtYZbU1HtRv5AYuci7EqJsIEkwN+s=; b=QhomsNqqUsnl3IZaIlvhoy5y2x5Hoj5e3YpaagEeVsRd1gBmFqnJIPYyntHnVnzyNk RPR1/2rVl88wXENbdyzMsBWIeg6NQPXYFMQsj8gXyDZDaR5xCQOB1IY6ukLA5Klv9qXu CE23BC0GQtcAKnqQhI7jdLFiK7sZzvLJ1To2APZRta21RQ1blDS3LxtUMomsBLBfDGcI e6HIkJ6VNn47i0P5vHujcG9LCV53Ah02EV/zDa8+kuGMqBxWDkMof+ZxiZdqIu6PflFV 5sXvGAk2pVgSVchafePuUwNkRG8JLbiX7vNd2uTCsn55JAGR6rANgsTK7dARmzRmtsfW 3RSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694574222; x=1695179022; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C1mvv2fqoAPFPTYtYZbU1HtRv5AYuci7EqJsIEkwN+s=; b=d6Zs9PEfaTZzuXcuxzcZJsQJ3XXgrjCZ6RD+37SSnvLC0yOjCC59Xil+cyEi+Dxk28 vC0hJrg82arpKkpFDTqbX8vx1Ivw6GReYUWHHsYMOkh1xTyPCt5txURZ9sTA0Jaf73xv 7dxyIJ/ZI/0jUpeDQ5h53pGZvMykNKaoUqgi4RK1XqqRWI/QQ00NsgR/9FPHapc2pYa+ qzRbNaW41EFWbCxa4hfx5IDi8Hu7n3u0sgunyR9BcEcWhiMYgaTDrGYGfE+xaxjW8GPZ rM4itRhjWSB/bwKEK280Fe/AsPYKGBF0RXi780P2BtP9Tk9HL6Inp5qBHrZqBXoaJs+s Velg== X-Gm-Message-State: AOJu0Ywj0/5JKdR3mXHXpEOWwiB42E4WSb5KrBkxcqkPbTwfiMZVrsMH XAAO22RPrg/7dP1NrGJAcK8Vpg== X-Google-Smtp-Source: AGHT+IEC/mr2xBXQWhQrVYj0egj6eylp74YG2LqK22wf2aUnjB+uKZGYbXk07s+kYzsQUec7J6nUOQ== X-Received: by 2002:a05:6870:8308:b0:1d5:f22f:7a00 with SMTP id p8-20020a056870830800b001d5f22f7a00mr1746403oae.27.1694574221888; Tue, 12 Sep 2023 20:03:41 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:6719:975f:f380:ebb5]) by smtp.gmail.com with ESMTPSA id c2-20020a056871034200b001c5a3e31474sm5795766oag.45.2023.09.12.20.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 20:03:41 -0700 (PDT) References: <20230907152018.1031257-1-luis.machado@arm.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 00/16] SME support for AArch64 gdb/gdbserver on Linux In-reply-to: <20230907152018.1031257-1-luis.machado@arm.com> Date: Wed, 13 Sep 2023 00:03:37 -0300 Message-ID: <87a5tqydti.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Luis Machado writes: > The following series enables SME 1 (Scalable Matrix Extension) support for > AArch64 gdb and gdbserver. > > SME expands on SVE by having a variable-sized matrix (ZA) of dimensions > SVL x SVL bytes. > > The first few patches and some intermediate ones refactor the code and fix > issues prior to enabling SME support, and thus could go in independently. > > I've kept them in the series as they are closely/logically related. > > Luis Machado (16): > [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux > [gdb/aarch64] refactor: Rename SVE-specific files > [gdb/gdbserver] refactor: Simplify SVE interface to read/write > registers > [gdb/aarch64] sve: Fix return command when using V registers in a > SVE-enabled target > [gdb/aarch64] sme: Enable SME registers and pseudo-registers > [gdbserver/aarch64] refactor: Adjust expedited registers dynamically > [gdbserver/aarch64] sme: Add support for SME > [gdb/aarch64] sve: Fix signal frame z/v register restore > [gdb/aarch64] sme: Signal frame support > [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes > [gdb/aarch64] sme: Support TPIDR2 signal frame context > [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping > register state to core files > [gdb/generic] corefile/bug: Fixup (gcore) core file target description > reading order > [gdb/aarch64] sme: Core file support for Linux > [gdb/testsuite] sme: Add SVE/SME testcases > [gdb/docs] sme: Document SME registers and features FWIW, I have gone through the patch series and haven't found any issues. Thank you for addressing my comments. So apart from the patches where Simon found some issues: Reviewed-by: Thiago Jung Bauermann -- Thiago