From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 5BA3D3857BA4 for ; Mon, 14 Aug 2023 16:26:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5BA3D3857BA4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id A98D8100443E1 for ; Mon, 14 Aug 2023 16:26:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VaOUqk31EC5NcVaOUquYEj; Mon, 14 Aug 2023 16:26:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=cqleL30i c=1 sm=1 tr=0 ts=64da55a6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=0JvyMI3_I_4OnK_uF2UA:9 a=zZCYzV9kfG8A:10:nop_mobile_phish_fin_urg a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rULklIrRzOfV7aVyWVrwQ17dwTmb4g6Ine94AjwZCnk=; b=JuUWmAvVCAjjxBtMP0aq1vI4HJ 9J7aDc/aS87jy5xp2UgY0biM0AJxZ4SQlixNbeh3w3/pXF+K9gVC96HtyJI5MwS3DutRalV8fojBs aZ8PTOSxLuoEa5KhWv7IpjJkv; Received: from 75-166-142-177.hlrn.qwest.net ([75.166.142.177]:46032 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qVaOU-002n5j-11; Mon, 14 Aug 2023 10:26:14 -0600 From: Tom Tromey To: Alan Modra via Gdb-patches Cc: Alan Modra , aburgess@redhat.com Subject: Re: sim regen preparation References: X-Attribution: Tom Date: Mon, 14 Aug 2023 10:26:12 -0600 In-Reply-To: (Alan Modra via Gdb-patches's message of "Mon, 14 Aug 2023 21:28:22 +0930") Message-ID: <87a5utzj2z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.142.177 X-Source-L: No X-Exim-ID: 1qVaOU-002n5j-11 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-142-177.hlrn.qwest.net (murgatroyd) [75.166.142.177]:46032 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Alan" == Alan Modra via Gdb-patches writes: Alan> Regerating sim loses commit 1be79b1ebfad from sim/lm32/cpu.h, a Alan> generated file, so this patch move those declarations to Alan> sim/lm32/sim-main.h. In other spots in gdb we stick a read-only header on generated files to avoid this sort of error, like: /* THIS FILE IS GENERATED -*- buffer-read-only: t -*- */ /* vi:set ro: */ Pity cgen doesn't do this. Alan> OK to apply? I don't mind the patch at all but I wonder why cgen generates calls to these functions but not declarations for them; whereas for other functions (e.g., "lm32bf_h_pc_get") it does generate the declarations. Tom