From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id 8F986385781F for ; Fri, 11 Aug 2023 20:35:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F986385781F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-791071b9a5eso78153439f.3 for ; Fri, 11 Aug 2023 13:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691786130; x=1692390930; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NugUGyspnSh3K/PXSi1uC/n+RxO+6qVCCS6ZHEHy0HQ=; b=hFJADEK6jqgRh4mD9uti45eKVrFDy5+XhZ8EV0vYe28gi2bhrhcWpJfIDYQh6dV5o/ 05oxgz7vmAs6jYDemdVAin7/6Wkg4pAJ59m95V6p4JTs3khohqnNNa+fOO4o1kzP2zJ3 BPrhpd8PZQUbJtCL63K8EbxSoK33SOn+GLikst8QSlADRn27K3wPbaq94ZVWUtJTQENk cr9MBEndheeSD9dloVZdHSx58odH2uuPZ697zEzoeuHqu5TOHa8A/SGIMU7GGyKBqptN aNVFn9EDOxp6kOu5f8Olu5nyDZHBJVqBf3lP25hQZ2JE5uUkSJlUjwJnXWuqEuC0y5TS dMgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691786130; x=1692390930; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NugUGyspnSh3K/PXSi1uC/n+RxO+6qVCCS6ZHEHy0HQ=; b=SYfP+xGE/U31GYDKSgJ6oGbje0myRRuyuk87ljSCE+TlOUbAU9LJ5cbv/UDqEi+a2W QRxkTcxdu6ffgOWde/I/E1JeGAQo6/ejjgFixROlUaM4+AmsmwsfcQrLUpwLFmjWqILi Q6o9JjMwBAHZTXkWpc+xIvgA7mZgKJtdiJtbETexE2AtbJgmX4W21M7f0xHrFX5ifQaU Pgtw5aLCFal2pjfdIekrR+sSZp+BQwPATe/GK3am9TFxr7ODNCV962f2yKihz14qGsaK /FWZu5S5AbEX9IVF2KLjbIgiPk2dhT73aOG5sEltu4PPUCuCBDIdVg5z8v61E0Fee9/W TKKA== X-Gm-Message-State: AOJu0YwkQjKBqo5q/YVVQkMBWo7ko+eG5KIKS669Y7Mlo+xWZNE8ZOjJ Bdersfm9grSaCnCnbXSDKApf8g== X-Google-Smtp-Source: AGHT+IHSkK8fCi+9a28YuDTcFeHEeD7S7l4gOWJ1vaBZSRVK41nmeJYexu2HZKKrBC7T2lwq2x6Ksw== X-Received: by 2002:a5d:9bd2:0:b0:787:ff98:c38c with SMTP id d18-20020a5d9bd2000000b00787ff98c38cmr4006127ion.10.1691786129785; Fri, 11 Aug 2023 13:35:29 -0700 (PDT) Received: from murgatroyd (71-211-152-221.hlrn.qwest.net. [71.211.152.221]) by smtp.gmail.com with ESMTPSA id gh11-20020a056638698b00b0042b61a5087csm1225903jab.132.2023.08.11.13.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 13:35:29 -0700 (PDT) From: Tom Tromey To: Carl Love Cc: Tom Tromey , Carl Love via Gdb-patches , Ulrich.Weigand@de.ibm.com Subject: Re: [PATCH] gdb.ada/mi_var_access.exp References: <87fs4p1tes.fsf@tromey.com> <9ba870d323b0d30ec36d4c3865ed937770d268ba.camel@us.ibm.com> X-Attribution: Tom Date: Fri, 11 Aug 2023 14:35:28 -0600 In-Reply-To: <9ba870d323b0d30ec36d4c3865ed937770d268ba.camel@us.ibm.com> (Carl Love's message of "Fri, 11 Aug 2023 10:14:24 -0700") Message-ID: <87a5ux1fn3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Carl" == Carl Love writes: Carl> I see I have a typo above. The test is expecting 1, but it is 0 on Carl> PowerPC, not 2 as stated above. Carl> -var-create A_String_Access * A_String_Access Carl> ^done,name="A_String_Access",numchild="0",value="0x0",type="pck.string_access",thread-id="1",has_more="0" Ok, I see the problem. The test is kind of bogus: A_String : String (3 .. 5) := "345"; -- STOP ... it stops at this line, but A_String may not be initialized here. I think your patch is fine. Approved-By: Tom Tromey Tom