From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id BFA7F3858D32 for ; Thu, 10 Aug 2023 16:56:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFA7F3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 06A5410046B21 for ; Thu, 10 Aug 2023 16:56:32 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id U8xbqFQi3sBigU8xbqXzyt; Thu, 10 Aug 2023 16:56:31 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ub+U9IeN c=1 sm=1 tr=0 ts=64d516c0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=ietXV0v0B2eDFCYXqjIA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eQIklYytbvrakP77/9vmtYW9cW1ZS/GF4dqq1c45Jig=; b=As07Kr9QP8EPM8ZCBn1UNsruf5 /rr1FxxLgs0BDxMO1U9CIvDLLMtpBapomf4mXbM3OckS7Zcxb0No/dbt7+11eNDJiUJamlZeqSF+5 2ZLKDd7o3ddLS0qclL0jJ6iOO; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:36906 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qU8xb-001EuB-1q; Thu, 10 Aug 2023 10:56:31 -0600 From: Tom Tromey To: "Ijaz, Abdul B via Gdb-patches" Cc: Tom Tromey , "Ijaz, Abdul B" , "JiniSusan.George@amd.com" , "eliz@gnu.org" , "blarsen@redhat.com" Subject: Re: [PATCH v4 3/4] gdb/infrun: handle stepping through functions with DW_AT_trampoline References: <20230801224744.24433-1-abdul.b.ijaz@intel.com> <20230801224744.24433-4-abdul.b.ijaz@intel.com> <87leetchg5.fsf@tromey.com> X-Attribution: Tom Date: Thu, 10 Aug 2023 10:56:29 -0600 In-Reply-To: (Abdul B. via Gdb-patches Ijaz's message of "Mon, 7 Aug 2023 08:08:53 +0000") Message-ID: <87a5uy3kg2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qU8xb-001EuB-1q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (murgatroyd) [71.211.152.221]:36906 X-Source-Auth: tom+tromey.com X-Email-Count: 22 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> It also seems a bit weird that skip_trampoline_functions only affects >> this one subset of trampoline functions. > So skip_trampoline_functions is so far only handling the skipping case > for trampolines indicated by DW_AT_trampoline and not for any other > case of these thunks emitted by compiler or by signal > trampolines. Since this case is pretty much defined case for > subroutines calling the target subroutine but not sure about others > but may be these solib calls filtering may also be handled with the > same. Please let me know if we want to filter other trampolines cases > using the same filter. Mostly it should be "on" case but > DW_AT_trampoline could be interesting for user if compiler emit it for > virtual functions and user want to see all the trampoline calls so > here there could be some cases for end user to see those trampoline > calls but for thunks or rest I don=E2=80=99t know so let me know then I c= an > asses of using the filter option for other trampolines. Well, it just seems strange to me that after this series we would have two different ways of handling trampolines, that depend on how the trampoline is represented by the compiler (something nearly no user will understand or care about), and that there will be two different ways to elide frames from a "bt" (there's another one for frame filters). If we think users don't want to see trampoline frames by default, by all means elide them, but the setting ought to make sense from a user perspective, not from a compiler implementer perspective. Tom