From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 21E7B3858C36 for ; Thu, 27 Jul 2023 11:04:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21E7B3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690455875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1s5A9g5zmz7N7k8CRqpdCtYbXJHdNfHNtNe4Eew8x7Q=; b=Y0cWSDcWCbzNOYWlukcNqRRb50U89Ht1HvNLWKyu6Zo7874eTlGOzHT4lTL1vYoYS1JSov q/tfVNKKmmhmNMbFWKRPVWIA9JK+Bqdc7MJcvOBfVKYuqpo8Goi2FNfekfjtWrvavZ4HgX udEsgx3xUG4jXtFfMDeN/ifPNlE2MSw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-daVLm3jrMjmFNY7yvfXnJA-1; Thu, 27 Jul 2023 07:04:34 -0400 X-MC-Unique: daVLm3jrMjmFNY7yvfXnJA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fd2e898badso3511655e9.0 for ; Thu, 27 Jul 2023 04:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690455873; x=1691060673; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1s5A9g5zmz7N7k8CRqpdCtYbXJHdNfHNtNe4Eew8x7Q=; b=iUoqFnI8OouGKumA9wUaz54Zsip1mqfD2elQG8+7QXKOcoiGeK0Zk1TGxjV/I1Nx/T 7JHwY9R9LhDfj3n2Wq942AT5KLtvK3FE7RTHGw36TB4kj0B1rtVMYW1B5bxMMvdHGNbl JDvxQeo78NU5XPaomSrQrhFbkWKm/RQhtvceBNhUffWsGGZiqinZYm4WRIzXxQGrYcN9 +EWy+pXXMyaHkeMJz+w4cX+Y5X+ZWFrlevslyhFLC0hIrLM1SaXCVjwxxeoLz9tg6w0z pzrU2kr8fw3CA492LEKRA7uzLpEnoslE3LoDouzfhT+KzDVlxCYzOdvzdYemJ38IO9ru iMmA== X-Gm-Message-State: ABy/qLYsH3jJ5Erbj/NYH5vTTTizr7qQiMyj7vMg4VVL5xEKvpzuMfoJ lkFjPn+BNOJPxBqGFbmkkuUjKa/2dGbwkMwTtMuyByOOBWCybPD58JRd5iVpjpBE5/cR+1otpiX jlaVtsvmhLjuUgMalwhvouw== X-Received: by 2002:a05:600c:1790:b0:3fa:ef97:1fa5 with SMTP id x16-20020a05600c179000b003faef971fa5mr1594949wmo.6.1690455873191; Thu, 27 Jul 2023 04:04:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlEmLYfLO0D3cos9uIOf9kTZregg5qqX5bHQSvMT2t4IZfZzb80PsCg4/oWI318OYjt2E3SN9Q== X-Received: by 2002:a05:600c:1790:b0:3fa:ef97:1fa5 with SMTP id x16-20020a05600c179000b003faef971fa5mr1594937wmo.6.1690455872843; Thu, 27 Jul 2023 04:04:32 -0700 (PDT) Received: from localhost (93.72.115.87.dyn.plus.net. [87.115.72.93]) by smtp.gmail.com with ESMTPSA id 3-20020a05600c234300b003fc16ee2864sm1510632wmq.48.2023.07.27.04.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 04:04:32 -0700 (PDT) From: Andrew Burgess To: Aaron Merey , gdb-patches@sourceware.org Cc: Aaron Merey Subject: Re: [PATCH 1/6 v2] gdb/debuginfod: Add debuginfod_section_query In-Reply-To: <87wn0f1jle.fsf@redhat.com> References: <20230601014347.3367489-1-amerey@redhat.com> <20230601014347.3367489-2-amerey@redhat.com> <87wn0f1jle.fsf@redhat.com> Date: Thu, 27 Jul 2023 12:04:31 +0100 Message-ID: <87a5vhfwe8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Aaron Merey writes: > >> v1: https://sourceware.org/pipermail/gdb-patches/2023-February/197455.html >> >> v2 improves the description of AC_DEBUGINFOD_SECTION and associated >> macro names. An if-statement in debuginfod_section_query is also >> replaced with a gdb_assert. >> >> Commit message: >> >> Add new function debuginfod_section_query. This function queries >> debuginfod servers for an individual ELF/DWARF section associated with >> a given build-id. >> >> Also check for libdebuginfod version >= 0.188 at configure time. >> debuginfod_section_query simply returns -ENOSYS if this condition >> is not met. > > This LGTM. > > I don't think this should be merged until there's a use for the new GDB > functions (when later patches are also approved). > > Approved-By: Andrew Burgess Actually, on thinking about this further, I'd like to withdraw this approval, and ask a question / make a suggestion: Why do we need AC_DEBUGINFOD and AC_DEBUGINFOD_SECTION? Couldn't you just replace AC_DEBUGINFOD with AC_DEBUGINFOD_SECTION? The SECTION version checks for 0.179 and 0.188 and sets the various flags based on whatever is found. You would need to update binutils by running autoreconf, which would set the new define, but binutils would just ignore that define and all would be good. I think I would split this first patch in two, the first part would update the autoconf macro and then run autoreconf in binutils and gdb. Cross post this to both mailing lists, and get this merged. Then rebase this GDB series on top of that, and now GDB can just start making use of the new #define. Thanks, Andrew