From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 22D873858C52 for ; Fri, 9 Jun 2023 13:39:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22D873858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 7D7F910049AA2 for ; Fri, 9 Jun 2023 13:39:45 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 7cLBqGRGGNX2a7cLBqmBCV; Fri, 09 Jun 2023 13:39:45 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=64832ba1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=3n5CSm6XGFbVpx8_p3UA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9xiiKkNSaRsNdinvpzzBA5wNR/b1gsuCbcXufUPYkyI=; b=XGL+57FFGDkXq84I/ADxV3pgQZ jojRrlNMGzYxgr4IwaFGYPgdk7I8PT+R6uSDjseN8ZpveD/ivXk2zQzsiuCGwsEFkxcR9cqNxJk5B xL/FkRx6t8rQunfnsgrDLG2Ko; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:38968 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q7cLB-000uHo-7t; Fri, 09 Jun 2023 07:39:45 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH] [gdb/tui] Factor out border-mode help text References: <20230521195933.5351-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 09 Jun 2023 07:39:44 -0600 In-Reply-To: (Tom de Vries via Gdb-patches's message of "Mon, 22 May 2023 11:09:51 +0200") Message-ID: <87a5x8ah5r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1q7cLB-000uHo-7t X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (murgatroyd) [75.166.136.83]:38968 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> OTOH, it changes the translation boundaries, and I'm not sure if the Tom> new parts still classify as "entire sentence". Tom> Then again, I was not able to find any files containing translations Tom> for gdb, so perhaps it doesn't matter. Yeah, gdb has a bunch of calls to gettext but nobody has ever gotten translations done or installed them in the tree. I think some of the build machinery is missing too... hard to recall, it's been ages since I looked at this. Tom> + const std::string help_attribute_mode (_("\ Tom> normal normal display\n\ ... Tom> + const std::string help_tui_border_mode Tom> + = (std::string ("\ Tom> +This variable controls the attributes to use for the window borders:\n") Tom> + + help_attribute_mode); ... The text here isn't passed through gettext. Just wrapping the constant string in _() is enough. Tom> + add_setshow_enum_cmd ("border-mode", no_class, tui_border_mode_enums, Tom> + &tui_border_mode, _("\ Tom> +Set the attribute mode to use for the TUI window borders."), _("\ Tom> +Show the attribute mode to use for the TUI window borders."), Tom> + help_tui_border_mode.c_str (), Does add_setshow_enum_cmd copy the string that's passed in? I wouldn't have thought so. If not, then this can lead to a use-after-free. Instead help_tui_border_mode would have to be 'static'. Tom> + const std::string help_tui_active_border_mode Tom> + = (std::string ("\ Tom> +This variable controls the attributes to use for the active window borders:\n") Tom> + + help_attribute_mode); Here too. And similarly with 'static' I think. Tom