From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 6E9693858D28 for ; Wed, 24 May 2023 19:00:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E9693858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 9AE5F10038A03 for ; Wed, 24 May 2023 19:00:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 1tj9qBrwMSOjl1tj9qwbCH; Wed, 24 May 2023 19:00:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ercacqlX c=1 sm=1 tr=0 ts=646e5ee3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=2rlLS1JVAAAA:8 a=8bZm7BATp1ys1U9zSjQA:9 a=zZCYzV9kfG8A:10:nop_mobile_phish_fin_urg a=-y79GXfwoCjg1VU16VqY:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G0yT9+M8VbJzy68+A+JFbjSCZn+XduwBrpSANMKHsYY=; b=oATsAinX9MGdmgr2VYkzEkw54a 9xN7BCONQzzvxWVgdbABD2Hn0mhl3kZpNwg8I5I5Rdx9TA6JVcSeoPELOpzZhWZkv7M8bEBrkcHwP MK+eBQF+ilA1woCsTDQltWAkX; Received: from 71-211-130-244.hlrn.qwest.net ([71.211.130.244]:50290 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q1tj9-000s6i-6G; Wed, 24 May 2023 13:00:51 -0600 From: Tom Tromey To: Ciaran Woodward Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix scoped_value_mark not working with empty value chain References: X-Attribution: Tom Date: Wed, 24 May 2023 13:00:50 -0600 In-Reply-To: (Ciaran Woodward's message of "Mon, 22 May 2023 14:42:18 +0000") Message-ID: <87a5xty2ot.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.244 X-Source-L: No X-Exim-ID: 1q1tj9-000s6i-6G X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-244.hlrn.qwest.net (murgatroyd) [71.211.130.244]:50290 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ciaran" == Ciaran Woodward writes: Ciaran> The scoped_value_mark helper class was setting its internal Ciaran> mark value to NULL to indicate that the value chain had already Ciaran> been freed to mark. Thanks for finding this. Ciaran> scoped_value_mark () Ciaran> : m_value (value_mark ()) Ciaran> + , m_freed (false) These days we prefer inline initialization... Ciaran> + bool m_freed; ... i.e., adding " = false" here. This is ok with this change. If you don't have commit access (I didn't look), just send a v2 and I will apply it. Tom