From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id 02F893858C1F for ; Tue, 14 Mar 2023 15:07:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 02F893858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x133.google.com with SMTP id 4so8788027ilz.6 for ; Tue, 14 Mar 2023 08:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678806430; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8JRwz8yfE0a+lc21i9oyd4TVJAbZ9LE9dpAqhbd5b4I=; b=fEQ7QMX/aUpMmKNZlDJWJ7YezzULJsFt/PSAVoub113ZCoKAQtpkjn+2yQkkLf+a6f ZY9taVwicXKA4iGOVXrsCPn4Fajs2ClHKdI2xcv5hsaf5716tRmFjmk5vNUB6XrcbZj1 Pfe/QT7XMhWYqp7JlkQxFkF/XOeOUe9HeSX6yk6M3+ut2ekxKs7GccMrH9Jbt29uUK/o jKZgx4o36BZ+iO/ta1Me/UysVi9wDsqHV/GJq/PN9BHab+Zsy+bEjS6WVPJJUKqsimmv 5Pb9laAWNdEjLE1pt2zV7TxtuJs3OcQhEmBpAgT2Kk8AE6+FS3YRPo+rR59Dtqmvjiet PZaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678806430; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8JRwz8yfE0a+lc21i9oyd4TVJAbZ9LE9dpAqhbd5b4I=; b=RReIyyvTLifyUXgoPjXYW6E25APGgM7kGCi0bnm5iwHP2jPEfUv4Lty7JgzbqMy13d MmVP2V4c6OcNMrL12IdJf8Z58XkvQ2/WF3kTwlu4GR2DCOVThSV7oabJ2eJu6YR+6S9T S7BVLycyubW/zR44hfqbnzREa/7H09qmjUhuaNu2RXLZW5jLmXFdjbwYNQlemonblaIg VRdk914ogfjgAzlOAUy9hh8TqcWDvt+JxE+dzpDVpe07FDsmx096+aGfdGdJfjbsdNQU q2w5d8S/X/bAbgiUAgyLQ+iDP7JMSq2DqRJ9LLsWg8MixrachrFeilGJN2cotDseY7Wq Pzjg== X-Gm-Message-State: AO0yUKULxyATByfJQ7vfDQYg1PsEm/Mw8pYmdxMISyOP5XVGVARo8ht6 EYwzWTx8Azf1uGZAQrXEztIFBmyHERTabwmKnKs= X-Google-Smtp-Source: AK7set/CSMk9W6+T3eKakkylM7yYsq/iRLtssEYBWo/zzFsMA7CBkh4r2iL2kJIOmnKGwZDw6X7EMQ== X-Received: by 2002:a92:c690:0:b0:315:365d:5358 with SMTP id o16-20020a92c690000000b00315365d5358mr2767082ilg.10.1678806430186; Tue, 14 Mar 2023 08:07:10 -0700 (PDT) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id x8-20020a02ac88000000b0040306bfd949sm864369jan.21.2023.03.14.08.07.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 08:07:09 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Implement DAP variables, scopes, and evaluate requests References: <20230223200806.2647349-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 14 Mar 2023 09:07:09 -0600 In-Reply-To: <20230223200806.2647349-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 23 Feb 2023 13:08:06 -0700") Message-ID: <87a60fjrs2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> The DAP code already claimed to implement "scopes" and "evaluate", but Tom> this wasn't done completely correctly. This patch implements these Tom> and also implements the "variables" request. Tom> After this patch, variables and scopes correctly report their Tom> sub-structure. This also interfaces with the gdb pretty-printer API, Tom> so the output of pretty-printers is available. I'm going to check this in now. Tom