public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>,
	 Simon Marchi <simark@simark.ca>,
	Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCHv3] gdb/c++: fix handling of breakpoints on @plt symbols
Date: Mon, 13 Feb 2023 07:14:12 -0700	[thread overview]
Message-ID: <87a61hwt3f.fsf@tromey.com> (raw)
In-Reply-To: <c9315691-00e3-b84f-206e-891876db8fb7@simark.ca> (Simon Marchi via Gdb-patches's message of "Fri, 10 Feb 2023 15:51:21 -0500")

>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Not really relevant for your patch but... just chatting.  I don't know
Simon> if it would be really inefficient, but reading this function, I dream of
Simon> some util function that would parse a demangled C++ function symbol into
Simon> some structured type (listing the namespaces, name, abi tags,
Simon> parameters, whether it is const or not, etc).  It would then be much
Simon> easier to work on that, rather than doing everything string-based.

We have something along these lines in cp-name-parser.py.  It creates
the same data structure that is used internally by the demangler.

I too wish this area could be improved, though I'm unsure of the best
route forward.

Tom

      parent reply	other threads:[~2023-02-13 14:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 13:55 [PATCH] " Andrew Burgess
2023-01-20 11:48 ` [PATCHv2] " Andrew Burgess
2023-01-30 15:13   ` Andrew Burgess
2023-02-08  9:36   ` Bruno Larsen
2023-02-10 19:09     ` Andrew Burgess
2023-02-13  9:31       ` Bruno Larsen
2023-02-08 22:22   ` Simon Marchi
2023-02-10 19:10     ` Andrew Burgess
2023-02-10 19:03   ` [PATCHv3] " Andrew Burgess
2023-02-10 20:51     ` Simon Marchi
2023-02-12  6:22       ` Andrew Burgess
2023-02-13 14:14       ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a61hwt3f.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).