From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id EB20A38493CA for ; Mon, 13 Feb 2023 14:14:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB20A38493CA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 5733910042E45 for ; Mon, 13 Feb 2023 14:14:14 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RZawppJnoBkq3RZawpzrEE; Mon, 13 Feb 2023 14:14:14 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DdHSFthW c=1 sm=1 tr=0 ts=63ea45b6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=_vVFVYo0uzWKgssAWf4A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=d8c4x1afAx5Yzil2NukEnmn/pD+HwYXq/hpZ6U/f+zw=; b=AE7kE1SmrvcgJxfhw5DxSAjk1I 45608mI6+R+lbA8cht09iruXIIkOr9BPcp+/0MXKXSqhFwxqV9d4wrRn/76o/bW/b9iBUXMb0Wfy8 VrGFmIOqTPx7RnY7vOONhJdgt; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:59976 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRZav-0021bu-Vp; Mon, 13 Feb 2023 07:14:14 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Andrew Burgess , Simon Marchi , Bruno Larsen Subject: Re: [PATCHv3] gdb/c++: fix handling of breakpoints on @plt symbols References: <29e560fd9c94874f0839924fa25557a7e8418ad3.1674215225.git.aburgess@redhat.com> <1e9534288b91692c94af288b12659b107ac590c8.1676055649.git.aburgess@redhat.com> X-Attribution: Tom Date: Mon, 13 Feb 2023 07:14:12 -0700 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Fri, 10 Feb 2023 15:51:21 -0500") Message-ID: <87a61hwt3f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRZav-0021bu-Vp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:59976 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Not really relevant for your patch but... just chatting. I don't know Simon> if it would be really inefficient, but reading this function, I dream of Simon> some util function that would parse a demangled C++ function symbol into Simon> some structured type (listing the namespaces, name, abi tags, Simon> parameters, whether it is const or not, etc). It would then be much Simon> easier to work on that, rather than doing everything string-based. We have something along these lines in cp-name-parser.py. It creates the same data structure that is used internally by the demangler. I too wish this area could be improved, though I'm unsure of the best route forward. Tom