From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id CAC143858C50 for ; Wed, 8 Feb 2023 14:44:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAC143858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 3D64010048ED4 for ; Wed, 8 Feb 2023 14:44:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id PlgHpTQjGUgguPlgHp0HWp; Wed, 08 Feb 2023 14:44:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ArorYMxP c=1 sm=1 tr=0 ts=63e3b541 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=20KFwNOVAAAA:8 a=zWetkWxgutVqDI0ZLPgA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iGq3Mqf1ykUciaI/cUvY3QgqQUm4/A4Wvk7XBgam2Zw=; b=XPvXPQI2eYC2RD+2QheSHznS4a Gpoj2diOYrmZY1ACItYeJXBwiybOaKtFr+216EbEmm2qTb3hbolltz/fHhRRIuS/XcJljlIkDVAt7 EULGlBiHVGmCZZHtF0iVXEY86; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:39930 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pPlgG-000X3S-Te; Wed, 08 Feb 2023 07:44:16 -0700 From: Tom Tromey To: Aaron Merey Cc: Tom Tromey , Aaron Merey via Gdb-patches Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading. References: <20230128040601.2927632-1-amerey@redhat.com> <87a622itys.fsf@tromey.com> <87edran5qf.fsf@tromey.com> X-Attribution: Tom Date: Wed, 08 Feb 2023 07:44:14 -0700 In-Reply-To: (Aaron Merey's message of "Tue, 31 Jan 2023 15:41:45 -0500") Message-ID: <87a61omd35.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pPlgG-000X3S-Te X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:39930 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey writes: Aaron> Setting pagination_enabled to false does stop the prompt in this case, Aaron> however during testing of the on-demand downloading feature that I'm Aaron> working on [1] I saw cases where this still didn't prevent the prompt. >> If clearing pagination_enabled results in paging, then that sounds like >> a serious bug. Looking at the code I don't see how it can happen. >> Could you track it down? Aaron> Sure I'll take a look at it. It occurred to me last night that this could be a subtle change introduced by the pager rewrite. Before, disabling pagination also disabled line splitting, and took an earlier exit. But now, if pagination is disabled for some output, those lines still "count" towards the total. So then when pagination is no longer disabled, a print might cause the pager to intervene. Is this what's happening in your case? If so, I'm not totally sure it is a bug. Normally disabling paging should be done because using the pager isn't safe or appropriate at some point in time. But having those lines still "count" seems alright, maybe even useful. Tom