From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 04DC73858D28 for ; Sat, 28 Jan 2023 15:01:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04DC73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id EEB2510044390 for ; Sat, 28 Jan 2023 15:01:33 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Lmhxp14sMM20mLmhxpuu1m; Sat, 28 Jan 2023 15:01:33 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=HrCzp2fS c=1 sm=1 tr=0 ts=63d538cd a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=0Xtfw44IyKajTmB59bEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VT2VUxnMK4KHC474Xgsi+MzbNktzdhTTgA75WyBRO+U=; b=OfNxvaQdK9aqE2FpfiecgB8Ibb GxzCHwWKQxEgc3mGu/247BkFAjhIdnyoLFW0MROxuQLRrJ+hf3zp4Yqvvr3O1tUzamiFreR+Xr3gM xEy8iAH+jbsoycQwIKnebo6YT; Received: from 75-166-146-144.hlrn.qwest.net ([75.166.146.144]:59710 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pLmhw-000Gzz-Da; Sat, 28 Jan 2023 08:01:33 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: Aaron Merey Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading. References: <20230128040601.2927632-1-amerey@redhat.com> X-Attribution: Tom Date: Sat, 28 Jan 2023 08:01:31 -0700 In-Reply-To: <20230128040601.2927632-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Fri, 27 Jan 2023 23:06:01 -0500") Message-ID: <87a622itys.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.144 X-Source-L: No X-Exim-ID: 1pLmhw-000Gzz-Da X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-144.hlrn.qwest.net (prentzel) [75.166.146.144]:59710 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: Aaron> In some cases the prompt "--Type for more, q to quit, c to Aaron> continue without paging--" can appear during a large series of Aaron> debuginfod downloads when lines_printed exceeds lines_allowed. Aaron> This is inconvenient plus ctrl-c during this prompt could leave some Aaron> of gdb's internal structures in a broken state. Aaron> Fix this by adding a bool count_lines_printed to control whether Aaron> lines_printed is incremented when a newline is printed. Set this Aaron> value to false when performing a download. There's already pagination_disabled for this. Or you can print to a stream other than gdb_stdout. However, my question is why pagination is even enabled at the likely spots where debuginfod might be called. I thought infrun generally disabled it. Tom