From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 7E4533858D28 for ; Wed, 25 Jan 2023 22:04:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E4533858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id CCCB410047D7C for ; Wed, 25 Jan 2023 22:04:35 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KnshpqHH4NX2aKnshpd6OA; Wed, 25 Jan 2023 22:04:35 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63d1a773 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=46eK7QlecSQDwW5iBHwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=whv+1o8B0PJPkMwODGxxXS1kqPn6wURDIAmJS0ihd4E=; b=VOAjbfFeobgIT9YRIN8nvcT2w/ 1U2/P6d4oTN5pXBbMwuVTfYk7lSUcwSee2RrLePdni7iHDk3HAb++wiVN8VYALK8a0DHJzn1aLH+V M17/htWMvgfBS7Ji8n1Q0gfoU; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:50566 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKnsh-0007A7-Dm; Wed, 25 Jan 2023 15:04:35 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 6/9] gdb/testsuite/dap: pass around dicts instead of ton objects References: <20230106185729.42372-1-simon.marchi@efficios.com> <20230106185729.42372-7-simon.marchi@efficios.com> X-Attribution: Tom Date: Wed, 25 Jan 2023 15:04:32 -0700 In-Reply-To: <20230106185729.42372-7-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Fri, 6 Jan 2023 13:57:26 -0500") Message-ID: <87a626tgnj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKnsh-0007A7-Dm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:50566 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Change-Id: I2ca47bea355bf459090bae8680c6a917350b5c3f Probably could use a commit message. The main issue with this is that dicts lose type information from the JSON. So, if we ever need to check the type of some value sent by gdb, we won't be able to. But I suppose we could always just add some new proc that returns the TON form and go from there. I don't recall if I've needed any such tests yet. Arguably maybe we should write one. Tom