From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by sourceware.org (Postfix) with ESMTPS id 3A5EE3858C66 for ; Thu, 12 Jan 2023 19:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A5EE3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-yb1-xb32.google.com with SMTP id 188so19848137ybi.9 for ; Thu, 12 Jan 2023 11:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sTLd7fVzGe1yIe5Rig9O4llsmkjWABmiB16BL9XuR0Y=; b=JRnKLxc63yS0PS1Dq1Bq7ygpZ+ousE/DyDFTs/I3RZ3CoPHDd2DR8z7Dhln9sTwghQ tJiaYQrCLdBRe2uqrIDqm++4S3cSv8RqzspGLSXvz7IAheVS0OW7Y/uNelOaCXG62CCt eNpCf1dTqDeqEGPMOoMFvju+WIyIkWzwpWmYv/3rrt4nQgOr9bMOOx0HjGcrLIvfKQiH OnEBq0aoa++DSkacnxPHNDyVP8rlTH7xbN8BAFE1OstoTZhXMP8BiMKJiZPRBt2oe4pb 6bxOpRTegmWOwWAdwe/TPoQZAg1FE1c13jWjpTmSxAPsQowDP+tlAkdONJju5xyCdRgf 2qTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sTLd7fVzGe1yIe5Rig9O4llsmkjWABmiB16BL9XuR0Y=; b=NCNqEZEVDCp76QCeP3tdMq+/N+mbQy0JXnZsUmW0uTfxvaJYQQN73be48qCwT/Yq/1 fV/nZ87vnqJrBia4qxGakNO7Jqu2Ktx1LNqbH8tQV5R36I8+bSZfsQXbeMNyvV17bdGC c1YNourrn2dOVbAAIMZGUfKw8+iDhZEQSQE3UKhjS8rjVEhB9DNF6JDxTOqUZqu6wWTf 8Mznnqg7Gnp3CVzigbK+83oghqjMyy2N+amG9aYJYX8FUgx5clO1pIq2GJpYr9SmHyZY 2hPevcHG7m5ST5c6IqTqvNNrLgziee8oKSTS3DSJr2h23CBZMgnaYY9m8MLjSkPZgdJr KRWA== X-Gm-Message-State: AFqh2kqinsoDzGLmQVmhXsUR7BgtbAeBYm1G68xkPH7ZlMWj++r0lo3d Wem3FUdfjDZaBjW+JlrHwED+pg== X-Google-Smtp-Source: AMrXdXvvZ98f7zKFdm9eeKWrp1QDKYJocC+w9cscB4T7GoLIrQK1I6fC4yHrH/gbzQQ8z46bwcQaUA== X-Received: by 2002:a5b:60a:0:b0:749:f433:23db with SMTP id d10-20020a5b060a000000b00749f43323dbmr69105020ybq.64.1673550843614; Thu, 12 Jan 2023 11:14:03 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id u12-20020a05620a430c00b006ee949b8051sm11229666qko.51.2023.01.12.11.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 11:14:03 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi via Gdb-patches , Tom Tromey Subject: Re: [PATCH] Increase size of main_type::nfields References: <20230111204418.376620-1-tromey@adacore.com> <061d47f1-fbe7-4d2f-6919-811061d0be9b@simark.ca> <87tu0w69rp.fsf@tromey.com> X-Attribution: Tom Date: Thu, 12 Jan 2023 12:14:02 -0700 In-Reply-To: (Simon Marchi's message of "Wed, 11 Jan 2023 17:33:40 -0500") Message-ID: <87a62n5zwl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> It's not really important from a practical point of view. But also, I'd Simon> be surprised if it broke anything, even without touching the callers. The simplest change needed one cast, but it seems to me that if we want this to work properly, all callers of num_fields and set_num_fields must be updated to use unsigned types. I'm looking into that. Tom