From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 9C5C53858D32 for ; Thu, 1 Dec 2022 17:56:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C5C53858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12f.google.com with SMTP id o13so1071654ilc.7 for ; Thu, 01 Dec 2022 09:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IowElipwFgPBN6CeUyMLUDXlnIh+BbUKQChm3mS+pF8=; b=AIS94QhVl7JkPY1lovPGr29ZiSPGFeJU6iZpKi9TedOgIEop3u6xpAaUMwXYD0zk2C Eqw8PlhDTy9Jk/zuKYVpfoe+bZu1T6TXUmepwLt43MrfSoOQZYsJgk0MVXRe+jIx2sCG KEbpxFzyerlyiPMvlGsp02TYxdpf6aoa0Hvpvwn7RE/m81+LX0y67/7dHFcT+sU7wnWj 2hUXGc072MR9YUY6yg05O7QGyMfhcD/ChWABAXs4hkP9Mto3N4jWsVJ2AVOiADE4vWF2 WSFVxdy4EGTnJY9xVIORGH7+YHVhOTRr11qAoyvMUPXIFL8GN217nNkeBLzagomGgVIf 3WiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IowElipwFgPBN6CeUyMLUDXlnIh+BbUKQChm3mS+pF8=; b=vXk+RE7d/Ync2rtgrh+1kL3QIdHS6bv70qhnUpCgM/i3UQi81JlmfKhO8OKHEqL8iT eRV954u4lRY2d25TdBxHDwh+jL5T7RE6rnrA5NlK/yOAPh0TyuRaeBqMPXJczK3cXp7G AnXdrpoeq0tQzko0IouRIe8e4U+v0zdsDQYox0W7QD9XIr/5p77wg2jlOSzmj3DqjjSx B1LdYNK/a7CA7TQy3A0a3tUCl4S0dl6Mj74UOfElHnUFm5Hk/FsRAXYvYUk4IteKMtPk PQkmJNjXaraC5rnFHMaLMESvczCC2gGpfnbUEll9MTEmUAVcH6ZALu9G7iDlVcT0OJBB U4/Q== X-Gm-Message-State: ANoB5pnaJ/3SSKMnk9bqqqyy4KWLx1J2HQW4Jn/trnheiJQeJSEVj41D lMWN47yiBeZXkaf1Yp0GKHBVSw== X-Google-Smtp-Source: AA0mqf4ti5wfLUHs1FslDz6Hug2bZkS32JxlxsER7WWQCAl5ecdNW176JRLw28XaiISbv5WulrUOBg== X-Received: by 2002:a92:dcc3:0:b0:300:ee15:9973 with SMTP id b3-20020a92dcc3000000b00300ee159973mr23264113ilr.234.1669917407792; Thu, 01 Dec 2022 09:56:47 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id z4-20020a05663822a400b003740de9fb65sm1873149jas.46.2022.12.01.09.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 09:56:47 -0800 (PST) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey via Gdb-patches , Tom Tromey Subject: Re: [PATCH 3/3] Add name canonicalization for C References: <20221107162356.3175221-1-tromey@adacore.com> <20221107162356.3175221-4-tromey@adacore.com> <87bkon1408.fsf@redhat.com> X-Attribution: Tom Date: Thu, 01 Dec 2022 10:56:46 -0700 In-Reply-To: <87bkon1408.fsf@redhat.com> (Andrew Burgess's message of "Thu, 01 Dec 2022 16:29:43 +0000") Message-ID: <87a647m2ht.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: >> - {DW_AT_name {unsigned integer}} >> + {DW_AT_name {unsigned int}} Andrew> I notice that a few lines above this we also have: Andrew> integer_label: DW_TAG_base_type { Andrew> {DW_AT_byte_size 4 DW_FORM_sdata} Andrew> {DW_AT_encoding @DW_ATE_signed} Andrew> {DW_AT_name integer} Andrew> } Andrew> which seems to have the same int/integer misnaming, though I guess it Andrew> isn't causing any problems. Maybe we should fix this anyway though, Andrew> just for consistency? Sure, no problem. The reason "unsigned integer" causes a problem is that this canonicalizes to "unsigned int integer". Maybe this is a bug in the canonicalizer, though it's also weird/"impossible" input. "integer" doesn't have this problem because it's just an ordinary identifier. Thanks for your reviews. Tom