public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Joel Brobecker <brobecker@adacore.com>,
	 gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: GDB 13 Release 2022-09-11 update
Date: Thu, 15 Sep 2022 16:41:34 -0600	[thread overview]
Message-ID: <87a670mfa9.fsf@tromey.com> (raw)
In-Reply-To: <1983cd06-68ec-e4e1-a2aa-200d016773bf@suse.de> (Tom de Vries's message of "Wed, 14 Sep 2022 17:58:37 +0200")

Tom> Perhaps it would be worth clarifying the status of support for .gdb_index.

Tom> It is the defacto standard for the index cache, but ada support is
Tom> broken ( https://sourceware.org/bugzilla/show_bug.cgi?id=29179 ).

Tom> Do we want to fix this?

Tom> Do we want to deprecate .gdb_index and start using .debug_names for
Tom> the index cache?

Tom> Or are we fine with the status quo (which then might need documenting)?

My impression is that .gdb_index never really worked correctly for Ada.
So, while that is a regression of sorts, since the feature isn't really
usable for Ada in general, it doesn't seem worthwhile to fix it.

I did make .debug_names work for Ada.  See commit 3b00ef10a2a ("Add Ada
support for .debug_names").  I'm not at my work machine right now but
IIRC this is tested internally.

As for the overall plan, my view is:

* .gdb_index is (or should be) deprecated.  It was good but now we can
  do better.  However...

* In order to switch over fully, we have to fix the bugs in .debug_names.
  Fixing the writing side is easy (I have a patch somewhere) but I
  haven't worked on the reader yet.

* Once that is done we could switch over the index cache, but this also
  requires some more work to handle the situation where the index needs
  a string that isn't already in .debug_str.

I don't mind if this situation is documented.  We could even make
.gdb_index writing fail for Ada, though it seems to me that for the
index cache it is better to just fail silently.  Based on the Ada
programs I've seen, the new DWARF reader seems plenty fast enough
anyway.

Tom

  reply	other threads:[~2022-09-15 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11 18:26 Joel Brobecker
2022-09-11 18:58 ` Philippe Waroquiers
2022-09-14 15:58 ` Tom de Vries
2022-09-15 22:41   ` Tom Tromey [this message]
2022-09-16 11:55     ` Tom de Vries
2022-09-19 23:26       ` Tom Tromey
2022-09-20  6:33         ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a670mfa9.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).