From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Change bookmark allocation
Date: Thu, 18 Aug 2022 08:03:14 -0600 [thread overview]
Message-ID: <87a681vecd.fsf@tromey.com> (raw)
In-Reply-To: <ec55a079-e77f-7863-14a1-918aaaa0b1db@simark.ca> (Simon Marchi's message of "Wed, 17 Aug 2022 14:09:35 -0400")
>> + struct symtab_and_line sal {};
Simon> {} is unnecessary here, symtab_and_line already initializes its fields.
Thanks, I did this.
>> + bookmark &b = all_bookmarks.emplace_back ();
Simon> I don't think this works in C++11, emplace_back returns void.
I never remember this one since it seems so implausible to me :)
Simon> Otherwise, LGTM.
I made the changes and I'm going to check it in.
Tom
prev parent reply other threads:[~2022-08-18 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:10 Tom Tromey
2022-08-17 18:09 ` Simon Marchi
2022-08-18 14:03 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a681vecd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).