From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 49CD33857BBF for ; Fri, 15 Jul 2022 17:21:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49CD33857BBF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 05C961003E9CE for ; Fri, 15 Jul 2022 17:21:12 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CP03oJt9HUff9CP03omxzO; Fri, 15 Jul 2022 17:21:12 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=e7XD9Yl/ c=1 sm=1 tr=0 ts=62d1a208 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=WGg__ZBKAAAA:8 a=TevHVF4b0aXPP5e2-mAA:9 a=zPJw14IRtzJpAMP0Qlwv:22 a=vwV2fA3wUQyfisxp2d0v:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SalWZpWs6Wtsosof+4XYzpPni5XPXhUpZt5MhCDpKKA=; b=EQiYOEBnai6cYAwyYlp9uFg8Or yomDn2J4/cdY+bIL/sx/lIObwypjtImnyySe5dh2iZyBnhwyoe+dDycDf6vGbskjDfELNlVTXfQzS v1Iq68XFNfE71AXWlwKYs0/5H; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56100 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCP03-002dUp-Dd; Fri, 15 Jul 2022 11:21:11 -0600 From: Tom Tromey To: Jiangshuai Li Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/csky complete csky_dwarf_reg_to_regnum References: <20220707020901.8085-1-jiangshuai_li@c-sky.com> X-Attribution: Tom Date: Fri, 15 Jul 2022 11:21:10 -0600 In-Reply-To: <20220707020901.8085-1-jiangshuai_li@c-sky.com> (Jiangshuai Li's message of "Thu, 7 Jul 2022 10:09:01 +0800") Message-ID: <87a69apa0p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oCP03-002dUp-Dd X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56100 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 17:21:24 -0000 >>>>> Jiangshuai Li writes: > + if (dw_reg >= CSKY_R0_REGNUM && dw_reg <= (CSKY_R0_REGNUM + 31)) This line and some others have too many parentheses. > + /* For Float and Vector pseudo registers. */ > + if ((dw_reg >= FV_PSEUDO_REGNO_FIRST) && (dw_reg <= FV_PSEUDO_REGNO_LAST)) > + { > + char name_buf[4]; > + > + xsnprintf (name_buf, sizeof (name_buf), "s%d", > + dw_reg - FV_PSEUDO_REGNO_FIRST); > + return user_reg_map_name_to_regnum (gdbarch, name_buf, > + strlen (name_buf)); This seems like a very roundabout approach. Is there a reason it's done this way? Tom