From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id D97DF3856275 for ; Wed, 1 Jun 2022 04:50:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D97DF3856275 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id F32A7100480A4 for ; Wed, 1 Jun 2022 04:50:55 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id wGJrnsrlPQs3CwGJrnuUoZ; Wed, 01 Jun 2022 04:50:55 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=A+Opg4aG c=1 sm=1 tr=0 ts=6296f02f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=mDV3o1hIAAAA:8 a=tqSc8ozlbArSgQQ1gV8A:9 a=DvZ5ixILWSEuw56YIEpp:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DOARzASia/MiJ/TVseIFNq8Sv4z8gdFHRuX2+01wTx8=; b=PehMNJaK/fcl8XyUfQXZHlpVj7 +WFCwV5dtv+r3yDaSkpn1ARx3RRORqrbUJ5hsCMkhKVPdii8IVwil6iBaMWIqvRjXPAkTcJ9t6Fqf /e5UQICf2nqTfwsNAtHg8AOfd; Received: from 71-211-167-178.hlrn.qwest.net ([71.211.167.178]:35016 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nwGJr-002byK-5E; Tue, 31 May 2022 22:50:55 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Change location_to_sals to a method References: <20220528024231.474534-1-tom@tromey.com> <20220528024231.474534-3-tom@tromey.com> X-Attribution: Tom Date: Tue, 31 May 2022 22:50:54 -0600 In-Reply-To: (Pedro Alves's message of "Mon, 30 May 2022 16:32:16 +0100") Message-ID: <87a6ax6l75.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.167.178 X-Source-L: No X-Exim-ID: 1nwGJr-002byK-5E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-167-178.hlrn.qwest.net (prentzel) [71.211.167.178]:35016 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 04:50:58 -0000 >>>>> "Pedro" == Pedro Alves writes: >> int thread, task; Pedro> These thread/task are masking the breakpoint fields, and then ... Ugh, I even looked for this. I looked at turning on -Wshadow instead of -Wshadow=local, since that would fix this problem. It's a bit of a slog, and we'd be at the mercy of system headers too, but maybe we want to do this? Meanwhile I filed a gcc feature request to add a new -Wshadow that is like local but also handles data members: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105798 Tom