Re: [PATCH] Finalize each cooked index separately

[Tom Tromey <tromey@adacore.com>]

>>>>> "Lancelot" == Lancelot SIX <lsix@lancelotsix.com> writes:

Lancelot> I have a couple of comments/suggestions inlined in the patch below.

Thank you for the review.

>> +  std::vector<cooked_index::range> result_range;

Lancelot> Since the result_range's expected size is already known, it is possible
Lancelot> to pre-allocate the associated storage with

Lancelot>   result_range.reserve (m_vector.size);

I've made this change in both spots.

>> +  /* Create a new range_chain, transferring in a vector of
>> +     sub-ranges.  */
>> +  range_chain (std::vector<Range> &&ranges)
>> +    : m_ranges (ranges)

Lancelot> Did you forget the std::move (ranges) here? Otherwise I think m_ranges
Lancelot> is initialized using a copy ctor instead of the intended move ctor.

Yes, oops.

Lancelot>     template<typename Ranges>
Lancelot>     range_chain (Ranges &&ranges)
Lancelot>       : m_ranges (std::forward<Ranges> (ranges))
Lancelot>       { }

I did this too.

Lancelot> I was wondering why the begin () and end () are not const.  Turns out
Lancelot> that they could become const if the following adjustments are done to
Lancelot> the iterator class:

I made these const and updated the iterator.

Tom