From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 39A0C3858D39 for ; Tue, 18 Jan 2022 18:52:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39A0C3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 6C28A1004870D for ; Tue, 18 Jan 2022 18:52:53 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9tbAnVyAAEaNC9tbBnPGKI; Tue, 18 Jan 2022 18:52:53 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=dJtjJMVb c=1 sm=1 tr=0 ts=61e70c85 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=DghFqjY3_ZEA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=veBgDJAT0rs2_oO5j4AA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GdqbADlQv0pWSRVFJWhjQGAsFk8heUpV11uQ/5krtCo=; b=pGkbdU0lO74xfp0n/QasH8zyxL Qna9z/IwWzGDpbTfh2IfQtee9b4xo2gC863wQqqzqghktJKrSXojXEL0vg7pUh+nxQqcAqxI9Q4M5 q8uCKmzMmfb/RYvHoj9GhL7sp; Received: from 75-166-134-30.hlrn.qwest.net ([75.166.134.30]:55914 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9tbA-000GIJ-87; Tue, 18 Jan 2022 11:52:52 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH] gdb: unbuffer all input streams when not using readline References: <20220117164051.1854133-1-aburgess@redhat.com> X-Attribution: Tom Date: Tue, 18 Jan 2022 11:52:51 -0700 In-Reply-To: <20220117164051.1854133-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 17 Jan 2022 16:40:51 +0000") Message-ID: <87a6fsev0c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.134.30 X-Source-L: No X-Exim-ID: 1n9tbA-000GIJ-87 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-134-30.hlrn.qwest.net (murgatroyd) [75.166.134.30]:55914 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 18:52:55 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> This commit should fix PR gdb/28711. What's actually going on is Andrew> pretty involved, and there's still a bit of the story that I don't Andrew> understand completely, however, from my observed results, I think that Andrew> the change I propose making here (or something very similar) is going Andrew> to be needed. Thanks for the great description of the problem. I haven't read the whole thread yet but I had a couple things to mention in response to this message. Andrew> 3. Tom is currently doing lots of gdb stream management changes and Andrew> I want to minimise the chances we'll conflict. FWIW my changes only affect output streams, I haven't touched input at all. Andrew> So, this commit just changes gdb_readline_no_editing_callback to Andrew> always unbuffer the input stream. https://sourceware.org/bugzilla/show_bug.cgi?id=7237 is about the lack of buffering for MI. If this patch goes in, I think we should probably just WONTFIX this bug. Tom