From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy9-pub.mail.unifiedlayer.com (alt-proxy16.mail.unifiedlayer.com [70.40.197.35]) by sourceware.org (Postfix) with ESMTPS id 64DF63858D28 for ; Sun, 19 Dec 2021 00:54:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64DF63858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id A8A8123CE25 for ; Thu, 16 Dec 2021 18:56:47 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id xvvrms1rKfVVxxvvrmQaZj; Thu, 16 Dec 2021 18:56:47 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SeAyytdu c=1 sm=1 tr=0 ts=61bb8bef a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IOMw9HtfNCkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=aMvoAdRJOqlHtJdJwyMA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PPuG4/9T2V7aB2ZjqVYjiqd8FbvydhLXuN1gMgyYG/4=; b=IRdWlhAuYdOJyOvuAowiUlIgeD UWnKDL2vdt7wfuJT+YAc8/F/Sy0HPmQK9LjlNc3vmxFGYe/ap3KkHVhrb1NghF5JOvHC6CKGEVREe TQUgLu/R5jNmankGlf7/+AmaQ; Received: from 75-166-130-34.hlrn.qwest.net ([75.166.130.34]:40474 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mxvvq-003kg7-Un; Thu, 16 Dec 2021 11:56:47 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 6/8] Add new gdbarch generator References: <20211215224513.1626598-1-tom@tromey.com> <20211215224513.1626598-7-tom@tromey.com> <488505bc-69fb-8c38-3a95-60173695ae72@polymtl.ca> X-Attribution: Tom Date: Thu, 16 Dec 2021 11:56:46 -0700 In-Reply-To: <488505bc-69fb-8c38-3a95-60173695ae72@polymtl.ca> (Simon Marchi's message of "Wed, 15 Dec 2021 21:01:39 -0500") Message-ID: <87a6h0xtsh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.34 X-Source-L: No X-Exim-ID: 1mxvvq-003kg7-Un X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-34.hlrn.qwest.net (localhost.localdomain) [75.166.130.34]:40474 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Dec 2021 00:54:11 -0000 Simon> I think it would be nice to do a pass of adding comments in gdbarch.py, Simon> for those who will come after us (or future us). I can do it if you'd Simon> like. I will do it. Simon> flake8 pointed these out, it's mostly just style, but would be nice to Simon> fix: I fixed these. There are some flake8 errors in gdbarch-components.py, but I didn't fix those. Most of them are due to how the file is loaded by gdbarch.py, and the remaining few are over-long comment lines that are pre-existing buglets in gdbarch.sh, I think. Simon> I don't have much else to say, I feel like nitpicking on this script Simon> would be a high level of bike-shedding. Thank you very much for picking Simon> this up and completing it! I don't mind tweaks, but we can also of course make changes afterward. >> +class Method(Function): >> + def param_list(self): >> + return self.set_list() >> + >> + def actuals(self, initial_comma=True): Simon> initial_comma is unused Fixed. Tom