From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.46.142]) by sourceware.org (Postfix) with ESMTPS id 6815B385BF85 for ; Tue, 16 Nov 2021 23:56:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6815B385BF85 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway22.websitewelcome.com (Postfix) with ESMTP id CE4542D7BC for ; Tue, 16 Nov 2021 17:56:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n8JhmaVn2lEGIn8JhmtI1E; Tue, 16 Nov 2021 17:56:45 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CUZLmaplQmY31CySqjuIFZvOLevXWsiFYxJPBh4HpIc=; b=u6Dm4Vlvtrae6GfhQWooBqqwFX gbdWdeH46GDQ6GOSVy5f87AcAiKBy6et+MTykC8ymw2+wEfrksjiOruPteDe5W+yCDh/RQvNRlDTN 5kIOA562PG/LJISD7UcIT7aQS; Received: from [161.98.8.2] (port=58458 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mn8Jh-002ut8-F5; Tue, 16 Nov 2021 16:56:45 -0700 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/32] Rewrite the DWARF "partial" reader References: <20211104180907.2360627-1-tom@tromey.com> <4a288a6a-63c4-e36e-da20-01ae3fd0955c@suse.de> X-Attribution: Tom Date: Tue, 16 Nov 2021 16:56:44 -0700 In-Reply-To: <4a288a6a-63c4-e36e-da20-01ae3fd0955c@suse.de> (Tom de Vries's message of "Sat, 6 Nov 2021 13:25:10 +0100") Message-ID: <87a6i31woz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.2 X-Source-L: No X-Exim-ID: 1mn8Jh-002ut8-F5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (localhost.localdomain) [161.98.8.2]:58458 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 23:56:48 -0000 Tom> This triggered a fair amount of times: Tom> ... Tom> $ grep -c "has duplicate debug_info_offset 0x0, ignoring .debug_aranges" LOG Tom> 40 I think this is something of a latent bug, and the fix I applied is to skip DWZ units in this loop. I don't think .debug_aranges can refer to a CU coming from the DWZ file. Tom> $ grep -c "DW_FORM_GNU_strp_alt used without .debug_str" LOG Tom> 16 Tom> ... I think this happens because I failed to consider DWZ files in the pre-reading patch. I've applied a fix to pre-read some of the debug sections from this file. I couldn't reproduce the bug myself. I really appreciate the testing you've done. I'll send v3 of the series once I do some more testing... I plan to regression test with a few different approaches (dwz, probably split DWARF too). Meanwhile the unpolished version is on the 'submit/no-more-psym' branch in my github. thanks, Tom