From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.91]) by sourceware.org (Postfix) with ESMTPS id CD6193983800 for ; Wed, 4 Aug 2021 16:18:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD6193983800 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 4C0D9A90C2 for ; Wed, 4 Aug 2021 11:18:22 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BJb4m4cpyLjoRBJb4mCqOn; Wed, 04 Aug 2021 11:18:22 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Bdbd+CepPF0DV94jkRBWEDSbbezftgCQNfGR8eEAzT0=; b=o0M5QKoosuwISQDUThb565t0Gw pYeM41wINCN5ZYQ4fTvv36/3KO0hPt0fv4rh6Wkuj4qxWftrfecw8zacj7FyeNYYQtwRL+ybKjz7r 7afPsYmJrpPRV0cnXEgVwanGu; Received: from 97-122-71-26.hlrn.qwest.net ([97.122.71.26]:53574 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mBJb3-000jIN-Vb; Wed, 04 Aug 2021 10:18:22 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/symtab] Implement addrmap_mutable_find References: <20210803144656.GA8040@delia> X-Attribution: Tom Date: Wed, 04 Aug 2021 10:18:21 -0600 In-Reply-To: <20210803144656.GA8040@delia> (Tom de Vries's message of "Tue, 3 Aug 2021 16:46:58 +0200") Message-ID: <87a6lx5gky.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.71.26 X-Source-L: No X-Exim-ID: 1mBJb3-000jIN-Vb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-71-26.hlrn.qwest.net (murgatroyd) [97.122.71.26]:53574 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 16:18:24 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> Currently addrmap_mutable_find is not implemented: Tom> ... Tom> static void * Tom> addrmap_mutable_find (struct addrmap *self, CORE_ADDR addr) Tom> { Tom> /* Not needed yet. */ Tom> internal_error (__FILE__, __LINE__, Tom> _("addrmap_find is not implemented yet " Tom> "for mutable addrmaps")); Tom> } Tom> ... Tom> I implemented this because I needed this during debugging, to be able to do: Nice. I also needed this for my DWARF scanner rewrite. My approach was slightly simpler, but yours has asserts, so is probably preferable. Anyway it looks fine to me. Tom