From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.45.27]) by sourceware.org (Postfix) with ESMTPS id DDF3F3858012 for ; Thu, 1 Apr 2021 17:47:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DDF3F3858012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id DC19F400DC142 for ; Thu, 1 Apr 2021 12:36:58 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S1PJl4KykmJLsS1PJlfY7j; Thu, 01 Apr 2021 12:47:01 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JXo1lukvi5asOc1cwUJXck0VcyjvRh63NYgKyUFbqio=; b=eqJBqxzeexYi1je0pQdgO9B/4K R06WtTVNjAUUbtoYrZTUqBNTY4mlKplUy77FN1bkyW80UYpMtfxZWOwLKTao8o+WFoA/ngCxkXrXx fL41Iidn+I4TsweasvF84Rtd3; Received: from 71-211-182-15.hlrn.qwest.net ([71.211.182.15]:44532 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lS1PJ-0019lA-61; Thu, 01 Apr 2021 11:47:01 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 3/4] gdb: pass objfile_per_bfd_storage instead of objfile to partial_symtab References: <20210322193417.2376788-1-simon.marchi@efficios.com> <20210322193417.2376788-4-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 01 Apr 2021 11:47:00 -0600 In-Reply-To: <20210322193417.2376788-4-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 22 Mar 2021 15:34:16 -0400") Message-ID: <87a6qhq4mj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.182.15 X-Source-L: No X-Exim-ID: 1lS1PJ-0019lA-61 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-182-15.hlrn.qwest.net (murgatroyd) [71.211.182.15]:44532 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 17:47:11 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Since partial_symtab is supposed to be objfile-independent (since series Simon> [1]), I think it would make sense for partial_symtab to not take an Simon> objfile as a parameter in its constructor. Definitely. Thanks for doing this. I had one nit: Simon> + /* Get the BFD this object is associated to. */ Simon> + Simon> + bfd *bfd_ () const Simon> + { Simon> + return m_bfd; Simon> + } This seems like an unusual choice of name for an accessor. Maybe 'get_bfd' instead? Tom