From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.150.114]) by sourceware.org (Postfix) with ESMTPS id 77424396AC18 for ; Sun, 21 Feb 2021 21:04:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77424396AC18 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D22911DF594 for ; Sun, 21 Feb 2021 15:04:22 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id DvtulDuHPiQiZDvtulVNVk; Sun, 21 Feb 2021 15:04:22 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=k6RaKuXDM0UVe6GxYbFdTOsR3zLUStyK84YbN43Qisk=; b=SFpTGAZ/9Gdf3AWGmgvjtyop6f DWqJLQXRM11N4H4Ff6wY8plWUkRKZVMBwSluVlVOF89KszNxnUBbujeMVUyVu1F1rBH3YWxroe+oN Z7HfC2cRTHXvuQPVrGkqkMciB; Received: from 97-122-70-152.hlrn.qwest.net ([97.122.70.152]:57784 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lDvtu-002LQJ-Gz; Sun, 21 Feb 2021 14:04:22 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , Libor Bukata Subject: Re: [PATCH 1/2] gdb: push target earlier in procfs_target::attach (PR 27435) References: <20210221155630.3026942-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Sun, 21 Feb 2021 14:04:21 -0700 In-Reply-To: <20210221155630.3026942-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Sun, 21 Feb 2021 10:56:29 -0500") Message-ID: <87a6rxku96.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.152 X-Source-L: No X-Exim-ID: 1lDvtu-002LQJ-Gz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-152.hlrn.qwest.net (localhost.localdomain) [97.122.70.152]:57784 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Feb 2021 21:04:25 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Tested by trying to attach on a process on gcc211 on the gcc compile Simon> farm. Simon> gdb/ChangeLog: Simon> PR gdb/27435 Simon> * inf-ptrace.c (struct target_unpusher): Move to target.h. Simon> (target_unpush_up): Likewise. Simon> * procfs.c (procfs_target::attach): Push target early. Use Simon> target_unpush_up to unpush target in case of error. Simon> * target.h (struct target_unpusher): Move here. Simon> (target_unpush_up): Likewise. FWIW this looks reasonable to me. Tom