From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.53.25]) by sourceware.org (Postfix) with ESMTPS id 1F5D43857804 for ; Mon, 25 Jan 2021 03:27:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1F5D43857804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 8E5B8400D3768 for ; Sun, 24 Jan 2021 21:21:09 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 3sXclhsVxuDoA3sXclqiiB; Sun, 24 Jan 2021 21:27:48 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jlo9772w4kEYUHG+brKUL+EFsCMJ5GIFodyFqmIcECI=; b=I1h6nt7IauvVq9eimt4eewEhWZ Guz7rln77RAyQVWBxAwTgdQET/SS3kHW71WiKGHunZj310rp5rQyrfgciXczCdTibUxhTa0YoVlQE zE+9c6EspFtkY9jNikCmWXEA7; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:39556 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l3sXc-002c22-1o; Sun, 24 Jan 2021 20:27:48 -0700 From: Tom Tromey To: Simon Marchi Cc: Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 009/203] what is this code for References: <20210101214723.1784144-1-tom@tromey.com> <20210101214723.1784144-10-tom@tromey.com> <20210103060009.GB285722@adacore.com> <3ecfae34-c2d5-873e-b67d-175beca08547@polymtl.ca> X-Attribution: Tom Date: Sun, 24 Jan 2021 20:27:47 -0700 In-Reply-To: <3ecfae34-c2d5-873e-b67d-175beca08547@polymtl.ca> (Simon Marchi's message of "Sun, 24 Jan 2021 21:28:48 -0500") Message-ID: <87a6sx7l1o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l3sXc-002c22-1o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:39556 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, NO_DNS_FOR_FROM, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, TXREP, T_SPF_TEMPERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jan 2021 03:27:51 -0000 Simon> So it's already covered. Tom, are these cases correctly handled with Simon> this series applied? I regression-tested it and compared and it passed; however I don't think this is explicitly handled, so I suspect that the comparison was wrong. Maybe this will need a new method on operation to be handled correctly. I'll take a look when I rebase the series and fix up the other comments. Tom