From: Tom Tromey <tom@tromey.com>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Don't close thread handles provided by WaitForDebugEvent
Date: Tue, 26 May 2020 14:29:26 -0600 [thread overview]
Message-ID: <87a71utp7d.fsf@tromey.com> (raw)
In-Reply-To: <20200524222448.11955-1-ssbssa@yahoo.de> (Hannes Domani via Gdb-patches's message of "Mon, 25 May 2020 00:24:47 +0200")
>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
Hannes> 2020-05-24 Hannes Domani <ssbssa@yahoo.de>
Hannes> * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
Hannes> Don't close thread handle.
Thanks, I found this, which seems to agree with your analysis:
https://docs.microsoft.com/en-us/windows/win32/api/debugapi/nf-debugapi-waitfordebugevent
So, I think this patch is ok.
Tom
prev parent reply other threads:[~2020-05-26 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200524222448.11955-1-ssbssa.ref@yahoo.de>
2020-05-24 22:24 ` Hannes Domani
2020-05-24 22:24 ` [PATCH 2/2] Don't close process handle " Hannes Domani
2020-05-26 20:30 ` Tom Tromey
2020-05-27 17:47 ` Hannes Domani
2020-05-26 20:29 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a71utp7d.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).