From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35734 invoked by alias); 7 Feb 2019 11:19:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35716 invoked by uid 89); 7 Feb 2019 11:19:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Feb 2019 11:19:08 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id B839A3F4B8 for ; Thu, 7 Feb 2019 05:19:06 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id rhhyg7UvBdnCerhhyg7gME; Thu, 07 Feb 2019 05:19:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NtF6RPE/tuXxx5fbMQnHEU4Y0ClJOLYiDsOotl196Wk=; b=fXpXc9QhTYlSvOR91ihvcOxza2 HOezAHP/G21hq8rosuu9lupEV8+coqTGw3M3rkgKMBe2ohnYuvfub1ZaO3pIMosAJFbLPpMwrM4Rx XiDXalm1zT2pBF63N+ivMJgUC; Received: from dhcp-guest.act-europe.fr ([194.98.77.127]:64418 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1grhhy-003u3h-5t; Thu, 07 Feb 2019 05:19:06 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] C++-ify struct thread_fsm References: <20190102232806.14123-1-tom@tromey.com> <1546521500.1926.9.camel@skynet.be> Date: Thu, 07 Feb 2019 11:19:00 -0000 In-Reply-To: <1546521500.1926.9.camel@skynet.be> (Philippe Waroquiers's message of "Thu, 03 Jan 2019 14:18:20 +0100") Message-ID: <87a7j77sns.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-02/txt/msg00058.txt.bz2 >>>>> "Philippe" =3D=3D Philippe Waroquiers = writes: Philippe> I have scanned the patch. FWIW, that all looks nice to me. Philippe> A minor comment below, on something that was there before the pat= ch. >> /* The thread that as current when the command was executed. */ >> =C2=A0=C2=A0 int thread; Philippe> This comment looks strange; maybe 'that was' ? I've fixed this. I'm going to re-run this through the buildbot (I don't recall whether I did this before), and if it looks ok, I will check it in. Tom