From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75592 invoked by alias); 30 Nov 2018 20:30:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15969 invoked by uid 89); 30 Nov 2018 20:30:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=inherited, clarity X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.151.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 20:30:22 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 43257CF7A64 for ; Fri, 30 Nov 2018 14:30:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SpQagNH0sSjJASpQagkDuB; Fri, 30 Nov 2018 14:30:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EzBJlokiH7hjcjEozms+h+6ZGFJnWUTiWrsB9Hx8W3Q=; b=UbC5T1qhMiqCBdi6FgcK86Q1Qy GLgZypD4pqEHzeQERL/+epZ75KIYiCRcZeXBBgNY0CH/ezR4GPfOlKehhCsmLvuiqmrv7eo8w8of8 Gt4e16ITu/ZXtYdds3VyaP9S8; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:58576 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSpQZ-002Asw-W8; Fri, 30 Nov 2018 14:30:20 -0600 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFC PATCH] Introduce dwarf2_cu::get_builder References: <20181023185715.23082-1-keiths@redhat.com> Date: Fri, 30 Nov 2018 20:30:00 -0000 In-Reply-To: <20181023185715.23082-1-keiths@redhat.com> (Keith Seitz's message of "Tue, 23 Oct 2018 11:57:15 -0700") Message-ID: <87a7lqmhpg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00586.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> This patch is an attempt to deal with a variety of bugs reported where Keith> GDB segfaults attempting to access a dwarf2_cu's builder. In certain Keith> circumstances, this builder can be NULL. I think it would be good to describe one such case in the commit message. I suppose there must be some spot that works on an inherited DIE in the context of its own CU? I found myself wondering where. Keith> I'm submitting this as an RFC rather than an actual patch because of the Keith> lack of coverage testing for all the places where get_builder() is used. I wouldn't be surprised if some of them aren't really reachable in the sense of ever being able to take the ancestor path. I'm not concerned about needing tests for every single point. Keith> +# This tests a segfault that occurs when reading inline_subroutine DIEs inlined_subroutine (missing the "d") Keith> +# bugzila mentioned above. For clarity, some "superfluous" DIES have Missing an "l" in bugzilla. The rest seems good to me. Thank you for the patch, and for reducing and rewriting the test case like this. Tom