From: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com, edjunior@gmail.com
Subject: Re: [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR
Date: Fri, 10 Aug 2018 20:09:00 -0000 [thread overview]
Message-ID: <87a7puhtl1.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <8181ddeb-6e12-69ce-f469-56fd9a939760@redhat.com>
Pedro Alves <palves@redhat.com> writes:
> Skimming the patch I noticed the duplicated test names/messages
> above. Take a look here:
>
> https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
>
> Here I'd use with_test_prefix, something like:
>
> with_test_prefix "something relevant" {
> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
> }
>
> gdb_test "stepi" "asm.*"
>
> with_test_prefix "something else" {
> gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*"
> gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*"
> }
I'll update all the tests. Should I send these in a V3, or as replies to
each patch in this thread?
> BTW, isn't the series NEWS-worthy?
I'll add an item there.
Thanks!
--
Pedro Franco de Carvalho
next prev parent reply other threads:[~2018-08-10 20:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 2:52 [PATCH v2 00/12] GDB support for more powerpc registers on linux Pedro Franco de Carvalho
2018-08-10 2:52 ` [PATCH v2 02/12] [PowerPC] Don't zero-initialize vector register buffers Pedro Franco de Carvalho
2018-08-10 14:30 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 11/12] [PowerPC] Reject tdescs with VSX and no FPU or Altivec Pedro Franco de Carvalho
2018-08-10 14:44 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 09/12] [PowerPC] Add support for TAR Pedro Franco de Carvalho
2018-08-10 7:32 ` Eli Zaretskii
2018-08-10 18:12 ` Pedro Franco de Carvalho
2018-08-10 14:41 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 04/12] [PowerPC] Remove rs6000_pseudo_register_reggroup_p Pedro Franco de Carvalho
2018-08-10 14:33 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 06/12] [PowerPC] Fix indentation in arch/ppc-linux-common.c Pedro Franco de Carvalho
2018-08-10 14:34 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 12/12] [PowerPC] Add support for HTM registers Pedro Franco de Carvalho
2018-08-10 7:34 ` Eli Zaretskii
2018-08-10 14:54 ` Ulrich Weigand
2018-08-10 15:12 ` [PATCH v2] " Pedro Franco de Carvalho
2018-08-10 2:52 ` [PATCH v2 05/12] [PowerPC] Fix two if statements in gdb/ppc-linux-nat.c Pedro Franco de Carvalho
2018-08-10 14:33 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 01/12] Zero-initialize linux note sections Pedro Franco de Carvalho
2018-08-10 14:27 ` Ulrich Weigand
2018-08-10 16:13 ` Tom Tromey
2018-08-10 18:11 ` Pedro Franco de Carvalho
2018-08-10 20:50 ` Tom Tromey
2018-08-10 2:52 ` [PATCH v2 03/12] Add decfloat registers to float reggroup Pedro Franco de Carvalho
2018-08-10 14:35 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 07/12] [PowerPC] Refactor have_ initializers in rs6000-tdep.c Pedro Franco de Carvalho
2018-08-10 14:34 ` Ulrich Weigand
2018-08-10 2:52 ` [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR Pedro Franco de Carvalho
2018-08-10 14:39 ` Ulrich Weigand
2018-08-10 19:38 ` Pedro Alves
2018-08-10 20:09 ` Pedro Franco de Carvalho [this message]
2018-08-13 16:30 ` Pedro Alves
2018-08-14 20:15 ` Pedro Franco de Carvalho
2018-08-10 3:19 ` [PATCH v2 10/12] [PowerPC] Add support for EBB and PMU registers Pedro Franco de Carvalho
2018-08-10 7:35 ` Eli Zaretskii
2018-08-10 14:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7puhtl1.fsf@linux.vnet.ibm.com \
--to=pedromfc@linux.ibm.com \
--cc=edjunior@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).