From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118069 invoked by alias); 10 Aug 2018 20:09:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116760 invoked by uid 89); 10 Aug 2018 20:09:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Hx-languages-length:886 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Aug 2018 20:09:38 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7AK4R73030951 for ; Fri, 10 Aug 2018 16:09:37 -0400 Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ksdefgspn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 10 Aug 2018 16:09:37 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Aug 2018 14:09:36 -0600 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 10 Aug 2018 14:09:34 -0600 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7AK9X8t9896316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Aug 2018 13:09:33 -0700 Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 187B5C605D; Fri, 10 Aug 2018 14:09:33 -0600 (MDT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D1142C605A; Fri, 10 Aug 2018 14:09:32 -0600 (MDT) Received: from pedro.localdomain (unknown [9.85.205.203]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 10 Aug 2018 14:09:32 -0600 (MDT) Received: by pedro.localdomain (Postfix, from userid 1000) id 2AA263C0472; Fri, 10 Aug 2018 17:09:30 -0300 (-03) From: Pedro Franco de Carvalho To: Pedro Alves , gdb-patches@sourceware.org Cc: uweigand@de.ibm.com, edjunior@gmail.com Subject: Re: [PATCH v2 08/12] [PowerPC] Add support for PPR and DSCR In-Reply-To: <8181ddeb-6e12-69ce-f469-56fd9a939760@redhat.com> References: <20180810025210.6942-1-pedromfc@linux.ibm.com> <20180810025210.6942-9-pedromfc@linux.ibm.com> <8181ddeb-6e12-69ce-f469-56fd9a939760@redhat.com> Date: Fri, 10 Aug 2018 20:09:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 18081020-0004-0000-0000-000014740540 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009519; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01071759; UDB=6.00551999; IPR=6.00851570; MB=3.00022641; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-10 20:09:34 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18081020-0005-0000-0000-0000886A1DEA Message-Id: <87a7puhtl1.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00297.txt.bz2 Pedro Alves writes: > Skimming the patch I noticed the duplicated test names/messages > above. Take a look here: > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique > > Here I'd use with_test_prefix, something like: > > with_test_prefix "something relevant" { > gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*" > gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*" > } > > gdb_test "stepi" "asm.*" > > with_test_prefix "something else" { > gdb_test "info reg dscr" "dscr.*0x0*20\[ \t\]+.*" > gdb_test "info reg ppr" "ppr.*0x0*8000000000000\[ \t\]+.*" > } I'll update all the tests. Should I send these in a V3, or as replies to each patch in this thread? > BTW, isn't the series NEWS-worthy? I'll add an item there. Thanks! -- Pedro Franco de Carvalho