From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][PATCH][symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count
Date: Thu, 19 Jul 2018 14:40:00 -0000 [thread overview]
Message-ID: <87a7qni90r.fsf@tromey.com> (raw)
In-Reply-To: <20180718171814.br2yfrfajkyk6i2j@delia> (Tom de Vries's message of "Wed, 18 Jul 2018 19:18:14 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> this patch (without test-case for now) generates a warning if
Tom> DW_AT_upper_bound or DW_AT_count is defined, but can't be translated. This
Tom> is triggered for current gcc in lto mode for vla test-cases.
Tom> F.i.:
Tom> ...
Tom> $ gcc gcc/testsuite/gcc.dg/guality/vla-1.c -g -O2 -flto \
Tom> -DPREVENT_OPTIMIZATION -o ./vla-1.exe
Tom> $ ./gdb -batch -ex "set complaints 10" -ex "file ./vla-1.exe"
Tom> During symbol reading, Unresolved DW_AT_upper_bound - DIE at 0x337
Tom> [in module vla-1.exe].
Tom> ...
Tom> Good idea?
I think so.
Tom> + if (attr_ub)
[...]
Tom> + if (attr_count)
The gdb style is to use a check against nullptr in these spots.
Tom
next prev parent reply other threads:[~2018-07-19 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 17:18 Tom de Vries
2018-07-19 14:40 ` Tom Tromey [this message]
2018-07-20 21:21 ` Tom de Vries
2018-07-25 18:55 ` Tom Tromey
2018-07-26 8:40 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7qni90r.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).