From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 2/8] Use counted_command_line everywhere
Date: Tue, 24 Apr 2018 23:18:00 -0000 [thread overview]
Message-ID: <87a7ts8a7b.fsf@tromey.com> (raw)
In-Reply-To: <ea99b3d5-3d82-c30f-1730-e05bf5f1a1b6@redhat.com> (Pedro Alves's message of "Tue, 24 Apr 2018 17:43:04 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> + gdb::unique_xmalloc_ptr<char> default_collect_line
>> + (xstrprintf ("collect %s", default_collect));
Pedro> string_printf ?
Actually, a few lines later:
>> + actions.reset (new struct command_line (simple_control,
>> + default_collect_line.release ()),
So this couldn't use string_printf without additional work.
Tom
next prev parent reply other threads:[~2018-04-24 23:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 19:16 [RFA 0/8] Various command-related improvements Tom Tromey
2018-04-19 19:16 ` [RFA 3/8] Make print_command_trace varargs Tom Tromey
2018-04-24 16:43 ` Pedro Alves
2018-04-19 19:16 ` [RFA 2/8] Use counted_command_line everywhere Tom Tromey
2018-04-24 16:43 ` Pedro Alves
2018-04-24 23:11 ` Tom Tromey
2018-04-24 23:18 ` Tom Tromey [this message]
2018-04-19 19:16 ` [RFA 4/8] Constify prompt argument to read_command_lines Tom Tromey
2018-04-24 16:43 ` Pedro Alves
2018-04-19 19:16 ` [RFA 8/8] Let gdb.execute handle multi-line commands Tom Tromey
2018-04-19 19:32 ` Eli Zaretskii
2018-04-24 16:44 ` Pedro Alves
2018-04-19 19:16 ` [RFA 7/8] Allow breakpoint commands to be set from Python Tom Tromey
2018-04-19 19:31 ` Eli Zaretskii
2018-04-24 16:43 ` Pedro Alves
2018-04-19 19:16 ` [RFA 6/8] Use function_view in cli-script.c Tom Tromey
2018-04-22 19:02 ` Pedro Alves
2018-04-24 23:38 ` Tom Tromey
2018-04-19 19:16 ` [RFA 5/8] Allow defining a user command inside a user command Tom Tromey
2018-04-24 16:43 ` Pedro Alves
2018-04-24 23:24 ` Tom Tromey
2018-04-19 19:16 ` [RFA 1/8] Allocate cmd_list_element with new Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7ts8a7b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).