From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146802-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 103250 invoked by alias); 24 Apr 2018 23:18:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 103236 invoked by uid 89); 24 Apr 2018 23:18:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: gateway22.websitewelcome.com
Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 23:18:56 +0000
Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19])	by gateway22.websitewelcome.com (Postfix) with ESMTP id CE0345C5B	for <gdb-patches@sourceware.org>; Tue, 24 Apr 2018 18:18:54 -0500 (CDT)
Received: from box5379.bluehost.com ([162.241.216.53])	by cmsmtp with SMTP	id B7D4fSnMHWCOCB7D4fNSBu; Tue, 24 Apr 2018 18:18:54 -0500
X-Authority-Reason: nr=8
Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:36504 helo=bapiya)	by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)	(Exim 4.89_1)	(envelope-from <tom@tromey.com>)	id 1fB7D4-003WDK-J0; Tue, 24 Apr 2018 18:18:54 -0500
From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [RFA 2/8] Use counted_command_line everywhere
References: <20180419191539.661-1-tom@tromey.com>	<20180419191539.661-3-tom@tromey.com>	<ea99b3d5-3d82-c30f-1730-e05bf5f1a1b6@redhat.com>
Date: Tue, 24 Apr 2018 23:18:00 -0000
In-Reply-To: <ea99b3d5-3d82-c30f-1730-e05bf5f1a1b6@redhat.com> (Pedro Alves's	message of "Tue, 24 Apr 2018 17:43:04 +0100")
Message-ID: <87a7ts8a7b.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-BWhitelist: no
X-Source-L: No
X-Exim-ID: 1fB7D4-003WDK-J0
X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:36504
X-Source-Auth: tom+tromey.com
X-Email-Count: 7
X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20=
X-Local-Domain: yes
X-SW-Source: 2018-04/txt/msg00494.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +      gdb::unique_xmalloc_ptr<char> default_collect_line
>> +	(xstrprintf ("collect %s", default_collect));

Pedro> string_printf ?

Actually, a few lines later:

>> +      actions.reset (new struct command_line (simple_control,
>> +					      default_collect_line.release ()),

So this couldn't use string_printf without additional work.

Tom