From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH v3 1/2] Create new common/pathstuff.[ch]
Date: Wed, 28 Feb 2018 16:46:00 -0000 [thread overview]
Message-ID: <87a7vtkqpj.fsf@redhat.com> (raw)
In-Reply-To: <7555f173-8517-ef9f-897c-e1934cc3b942@ericsson.com> (Simon Marchi's message of "Wed, 28 Feb 2018 00:01:48 -0500")
On Wednesday, February 28 2018, Simon Marchi wrote:
> On 2018-02-27 10:27 PM, Sergio Durigan Junior wrote:
>> diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c
>> index cb02b58507..922d5269b3 100644
>> --- a/gdb/gdbserver/server.c
>> +++ b/gdb/gdbserver/server.c
>> @@ -56,6 +56,10 @@
>> break; \
>> }
>>
>> +/* String containing the current directory (what getwd would return). */
>> +
>> +char *current_directory;
>> +
>> /* The environment to pass to the inferior when creating it. */
>>
>> static gdb_environ our_environ;
>> @@ -3539,6 +3543,13 @@ captured_main (int argc, char *argv[])
>> const char *selftest_filter = NULL;
>> #endif
>>
>> + current_directory = getcwd (NULL, 0);
>> + if (current_directory == NULL)
>> + {
>> + error (_("%s: error finding working directory"),
>> + safe_strerror (errno));
>> + }
>
> Just one thing, I think Pedro suggested to put the variable string at the end:
>
> error (_("Could not find working directory: %s"),
> safe_strerror (errno));
Ah, that's right, sorry about this, I got confused. And I didn't get
this message on my INBOX, so I went ahead and pushed the commit without
this change. I took the liberty to push an obvious commit now fixing
this.
815615463b1171cbff7c5e54f62fc708cc1bbc99
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2018-02-28 16:46 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 1:42 [PATCH 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-02-10 1:42 ` [PATCH 2/2] " Sergio Durigan Junior
2018-02-12 4:18 ` Simon Marchi
2018-02-12 19:16 ` Sergio Durigan Junior
2018-02-21 8:05 ` Joel Brobecker
2018-02-12 19:57 ` [PATCH 0/2] " Sergio Durigan Junior
2018-02-12 19:57 ` [PATCH v2 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-12 19:57 ` [PATCH v2 2/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-02-13 4:35 ` Simon Marchi
2018-02-22 18:37 ` Sergio Durigan Junior
2018-02-21 12:29 ` Pedro Alves
2018-02-27 0:20 ` Sergio Durigan Junior
2018-02-28 3:32 ` Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 0/2] " Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 2/2] " Sergio Durigan Junior
2018-02-28 3:58 ` Sergio Durigan Junior
2018-02-28 5:33 ` Simon Marchi
2018-02-28 7:09 ` Metzger, Markus T
2018-02-28 16:30 ` Sergio Durigan Junior
2018-02-28 5:46 ` Simon Marchi
2018-02-28 16:29 ` Sergio Durigan Junior
2018-02-28 16:40 ` Sergio Durigan Junior
2018-02-28 3:27 ` [PATCH v3 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-28 5:02 ` Simon Marchi
2018-02-28 16:46 ` Sergio Durigan Junior [this message]
2018-02-28 16:39 ` Sergio Durigan Junior
2018-03-01 2:23 ` [PATCH v3 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-03-01 2:55 ` Joel Brobecker
2018-03-01 13:08 ` Christophe Lyon
2018-03-01 13:18 ` Simon Marchi
2018-03-01 19:50 ` Sergio Durigan Junior
2018-03-01 20:20 ` [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*) Sergio Durigan Junior
2018-03-01 20:47 ` Simon Marchi
2018-03-02 11:46 ` Christophe Lyon
2018-03-02 12:35 ` Sergio Durigan Junior
2018-03-02 11:11 ` Yao Qi
2018-03-02 12:29 ` Sergio Durigan Junior
2018-03-02 12:37 ` Sergio Durigan Junior
2018-03-05 12:07 ` Yao Qi
2018-03-02 13:32 ` Eli Zaretskii
2018-03-02 15:15 ` Simon Marchi
2018-03-02 18:20 ` Sergio Durigan Junior
2018-03-03 7:36 ` Eli Zaretskii
2018-03-01 17:37 ` [PATCH v3 0/2] Make gdbserver work with filename-only binaries Sergio Durigan Junior
2018-03-02 3:20 ` Joel Brobecker
2018-02-28 16:47 ` [obvious/pushed] Change order of error message printed when gdbserver can't find CWD Sergio Durigan Junior
2018-02-10 1:42 ` [PATCH 1/2] Create new common/pathstuff.[ch] Sergio Durigan Junior
2018-02-11 22:14 ` Simon Marchi
2018-02-12 19:01 ` Sergio Durigan Junior
2018-02-21 7:56 ` Joel Brobecker
2018-02-22 18:43 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7vtkqpj.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).