From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make 'symbol-file' not care about the position of command line arguments
Date: Thu, 30 Nov 2017 04:07:00 -0000 [thread overview]
Message-ID: <87a7z49zou.fsf@redhat.com> (raw)
In-Reply-To: <d5732654-f494-ed31-ef9d-7bfe3ef1f20d@redhat.com> (Pedro Alves's message of "Thu, 30 Nov 2017 00:34:51 +0000")
On Wednesday, November 29 2017, Pedro Alves wrote:
> On 11/30/2017 12:08 AM, Sergio Durigan Junior wrote:
>> On Wednesday, November 29 2017, Pedro Alves wrote:
>>
>> I'll wait until we reach a conclusion on whether this patch is useful or
>> not, and then submit the testcase along with v2.
>
> I don't mind this going in, provided it comes with a testcase.
I'm working on it right now.
>>>> I've always considered that passing '--' is the de facto way
>>>> of telling getopt (or argp) to stop processing.
>>>
>>> "--" is used to stop processing options when you want to pass
>>> a non-option argument that starts with "-", like imagine if you
>>> wanted to pass a filename that starts with "-" to symbol-file
>>> (the filename is not an option.)
>>
>> Ah, true, that makes sense.
>>
>
> ... which points out that we should really handle "--", for
> the possibility of such filenames.
>
> (At some point we should really come up with some getopt-like
> API that can be used by all the commands that also use gdb_argv,
> to help with normalizing the interface, and also to make it
> easier to add new options to commands.)
That'd be super. It's been on my mind for quite some time, too. I'm
impressed such interface doesn't exist yet.
>>> Note that supporting non-option arguments before options
>>> is impossible for commands that need to handle raw arguments.
>>> I.e., commands that want to supporting passing arguments
>>> arguments with spaces, without forcing the user to wrap it
>>> all in quotes. Like "break -q function (int)", or
>>> "print /x EXPRESSION_WITH_SPACES", etc. (I have a WIP series
>>> that adds '-'-options to "print", btw.)
>>> It's good to keep the possibility of the command being extended
>>> in that direction in mind. It doesn't seem to be the case
>>> here, but that's the angle I was coming from.
>>
>> I agree, but that's not the case with 'symbol-file' or
>> 'add-symbol-file', right?
>
> Yes, that's what I said - "it doesn't seem to be the case here".
>
> Are we still negotiating? Can I get you to make
> "add-symbol-file" process options in any position too? :-)
Sure thing! I'll give it a try.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-11-30 4:07 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 20:54 [RFC/RFA] Add support for the --readnever command-line option (DWARF only) Joel Brobecker
2016-07-12 14:27 ` Yao Qi
2016-10-04 18:07 ` Pedro Alves
2017-11-23 0:54 ` [PATCH v2] " Sergio Durigan Junior
2017-11-23 12:09 ` Pedro Alves
2017-11-23 17:21 ` Sergio Durigan Junior
2017-11-23 17:29 ` Pedro Alves
2017-11-24 4:54 ` Sergio Durigan Junior
2017-11-24 13:18 ` Pedro Alves
2017-11-24 20:27 ` Sergio Durigan Junior
2017-11-27 19:13 ` Pedro Alves
2017-11-29 0:59 ` Sergio Durigan Junior
2017-11-29 12:23 ` Pedro Alves
2017-11-23 15:59 ` Eli Zaretskii
2017-11-23 19:36 ` Sergio Durigan Junior
2016-10-04 18:06 ` [RFC/RFA] " Pedro Alves
2017-11-24 23:01 ` [PATCH v2] Add support for the --readnever command-line option Sergio Durigan Junior
2017-11-25 7:33 ` Eli Zaretskii
2017-11-25 16:41 ` Sergio Durigan Junior
2017-11-25 17:16 ` Eli Zaretskii
2017-11-29 1:21 ` [PATCH v3] Add support for the readnever concept Sergio Durigan Junior
2017-11-29 3:39 ` Eli Zaretskii
2017-11-29 12:25 ` Pedro Alves
2017-11-29 18:43 ` Sergio Durigan Junior
2017-11-29 21:45 ` [PATCH] Make 'symbol-file' not care about the position of command line arguments Sergio Durigan Junior
2017-11-29 22:26 ` Pedro Alves
2017-11-29 22:42 ` Sergio Durigan Junior
2017-11-29 23:15 ` Pedro Alves
2017-11-30 0:08 ` Sergio Durigan Junior
2017-11-30 0:34 ` Pedro Alves
2017-11-30 4:07 ` Sergio Durigan Junior [this message]
2017-11-30 4:25 ` [PATCH v2] Make '{add-,}symbol-file' " Sergio Durigan Junior
2017-11-30 10:57 ` Pedro Alves
2017-11-30 12:38 ` Sergio Durigan Junior
2017-11-30 12:49 ` Pedro Alves
2017-11-30 13:06 ` Sergio Durigan Junior
2017-11-30 13:33 ` [PATCH v3] " Sergio Durigan Junior
2017-11-30 15:01 ` Pedro Alves
2017-11-30 17:26 ` Sergio Durigan Junior
2017-11-30 17:37 ` Pedro Alves
2017-11-30 17:43 ` Sergio Durigan Junior
2017-11-30 17:50 ` Pedro Alves
2017-11-30 20:00 ` [PATCH v4] " Sergio Durigan Junior
2017-12-01 12:11 ` Pedro Alves
2017-12-01 17:41 ` Sergio Durigan Junior
2017-12-01 21:45 ` Pedro Alves
2017-12-01 22:02 ` Sergio Durigan Junior
2017-11-30 0:25 ` [PATCH v4] Add support for the readnever concept Sergio Durigan Junior
2017-11-30 11:53 ` Pedro Alves
2017-12-01 4:35 ` Sergio Durigan Junior
2017-12-01 12:43 ` Pedro Alves
2017-12-01 17:19 ` Tom Tromey
2017-12-01 17:21 ` Sergio Durigan Junior
2017-12-01 20:00 ` Pedro Alves
2017-12-01 22:16 ` [PATCH v5] " Sergio Durigan Junior
2017-12-01 23:19 ` Pedro Alves
2017-12-02 2:31 ` Sergio Durigan Junior
2017-12-02 8:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7z49zou.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).